Fix to ElementTransformer for GRAPH.

apache · Mar 17, 2016 · bc5ace0 · bc5ace0
1 parent c7b83db
commit bc5ace0
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/jena-arq/src/main/java/org/apache/jena/sparql/syntax/syntaxtransform/ElementTransformer.java b/jena-arq/src/main/java/org/apache/jena/sparql/syntax/syntaxtransform/ElementTransformer.java
@@ -204,15 +204,15 @@ private boolean transformFromTo(List<Element> elts, List<Element> elts2) {
         public void visit(ElementDataset el) {
             Element sub = pop() ;
             Element el2 = transform.transform(el, sub) ;
-            push(el) ;
+            push(el2) ;
         }
 
         @Override
         public void visit(ElementNamedGraph el) {
             Node n = el.getGraphNameNode() ;
             Node n1 = transformNode(n) ;
             Element elt1 = pop() ;
-            Element el2 = transform.transform(el, n, elt1) ; 
+            Element el2 = transform.transform(el, n1, elt1) ; 
             push(el2) ;
         }
 
@@ -252,10 +252,8 @@ public void visit(ElementMinus el) {
 
         @Override
         public void visit(ElementService el) {
-            boolean b = el.getSilent() ;
             Node n = el.getServiceNode() ;
             Node n1 = transformNode(n) ;
-            Element elt = el.getElement() ;
             Element elt1 = pop() ;
             Element el2 = transform.transform(el, n1, elt1) ;
             push(el2) ;

diff --git a/...-arq/src/test/java/org/apache/jena/sparql/syntax/syntaxtransform/TestSyntaxTransform.java b/...-arq/src/test/java/org/apache/jena/sparql/syntax/syntaxtransform/TestSyntaxTransform.java
@@ -76,11 +76,22 @@ public class TestSyntaxTransform extends BaseTest
                   "o", "1");
     }
 
-    @Test public void subst_query_11() { testQuery
-        ("SELECT * { ?s ?p ?o { SELECT ?x { ?x ?p ?o } } }",
-         "SELECT * { ?s ?p 1  { SELECT ?x { ?x ?p 1 } } }",
-         "o", "1") ; }
+    @Test public void subst_query_11() { 
+        testQuery("SELECT * { ?s ?p ?o { SELECT ?x { ?x ?p ?o } } }",
+                  "SELECT * { ?s ?p 1  { SELECT ?x { ?x ?p 1 } } }",
+                  "o", "1") ; }
+
+    @Test public void subst_query_20() { 
+        testQuery("SELECT * { ?s ?p ?g GRAPH ?g { ?s ?p ?g } }",
+                  "SELECT * { ?s ?p <urn:graph> GRAPH <urn:graph> { ?s ?p <urn:graph> } }",
+                  "g", "<urn:graph>") ; }
 
+    @Test public void subst_query_21() { 
+        testQuery("SELECT * { ?s ?p ?srv SERVICE ?srv { ?s ?p ?srv}}",
+                  "SELECT * { ?s ?p <urn:service> SERVICE <urn:service> { ?s ?p <urn:service>}}",
+                  "srv", "<urn:service>") ; }
+
+
     @Test public void subst_update_01() { 
         testUpdate("DELETE { ?s <urn:p> ?x } WHERE {}", 
                    "DELETE { ?s <urn:p> <urn:x> } WHERE {}",