Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENA-2155: Add Web Access Control Ontology #1064

Merged
merged 5 commits into from
Sep 5, 2021
Merged

JENA-2155: Add Web Access Control Ontology #1064

merged 5 commits into from
Sep 5, 2021

Conversation

ebremer
Copy link
Contributor

@ebremer ebremer commented Sep 3, 2021

@afs afs self-requested a review September 4, 2021 09:01
@afs
Copy link
Member

afs commented Sep 4, 2021

Hi @ebremer,

What's the long term situation here? Is the work in Solid a different namespace? Is it compatible with this (up to 2016) vocabulary?

public static final Property defaultForNew = Init.defaultForNew();
public static final Property owner = Init.owner();

public static class Init {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't need the "Init"

Use of "Init" is needed in RDF.java uniquely to stop class preliminary initialization problems within jena-core. It arises because Jena internally uses RDF constants. Once jena-core initialization (which is the earliest) then everything should be normal.

If you encountered a problem, we need to track it down.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems. Was following the code for RDF. I removed the Init function. Added the final new line.

public static final Node defaultForNew = Init.defaultForNew().asNode();
public static final Node owner = Init.owner().asNode();
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: missing final newline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@afs afs changed the title Add Web Access Control Ontology JENA-2155: Add Web Access Control Ontology Sep 4, 2021
@afs
Copy link
Member

afs commented Sep 4, 2021

Maybe the class name should be WebAccessControl.

@ebremer
Copy link
Contributor Author

ebremer commented Sep 4, 2021

The name space is the same as what is used in Solid: https://solid.github.io/web-access-control-spec/
The long term goal is to track those newer changes introduced by the Solid project. I called the class "ACL" as it was short and convenient and followed their prefix abbreviation ACL.

@afs
Copy link
Member

afs commented Sep 4, 2021

Thanks for the updates.

How about WebACL? It's just "ACL" just feels a bit weak because this is specific to web operations.
(It should be "WAC" from the wiki ... wonder why that hasn't taken off!)

Vocabularies don't have to be in jena itself - it does not convey any magic to them - but this is a W3C work. If Solid add something, presumably it will go in a different namespace or get community agreement.

@ebremer
Copy link
Contributor Author

ebremer commented Sep 4, 2021

WAC would fine with me. Keeps it short and less ambiguous. What say you?

@afs
Copy link
Member

afs commented Sep 4, 2021

OK

@ebremer
Copy link
Contributor Author

ebremer commented Sep 5, 2021

Done.

@afs afs merged commit 867f063 into apache:main Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants