JENA-2256: Upgrades #1167
Merged
JENA-2256: Upgrades #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvesse
reviewed
Jan 19, 2022
pom.xml
Outdated
| @@ -840,6 +839,9 @@ | |||
| <message>No SNAPSHOT dependencies are allowed!</message> | |||
| <onlyWhenRelease>true</onlyWhenRelease> | |||
| </requireReleaseDeps> | |||
| <requireMavenVersion> | |||
| <version>3.2.5</version> | |||
There was a problem hiding this comment.
If we're gonna enforce this at all might want to enforce 3.8.1 (https://maven.apache.org/docs/3.8.1/release-notes.html) because that has some supply chain CVE related fixes
There was a problem hiding this comment.
3.2.5 was just the number the versions plugins referred to.
That's a good reason to go to 3.8.1 (released 2021-03-30).
Done.
kinow
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of note:
Lucene: 8.10.1 -> 8.11.1
This was noted by the maven-version-plugin. It is just making explicit the minimum maven version. Maven version 3.2.5 was released 2017-10-18. Current maven is 3.8.4.