Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENA-2260: Upgrade yarn from 0.16.x to 1.22.x #1175

Merged
merged 2 commits into from Jan 25, 2022
Merged

Conversation

kinow
Copy link
Member

@kinow kinow commented Jan 25, 2022

Would be better to go to v2.x (called Berry), but I couldn't figure out how to tell the Maven plug-in to use the 2.x version yet. 1.x is still maintained, so we should be fine.

Also adds --frozen-lockfile. It won't update yarn.lock anymore, and will fail in case the lock file gets updated/out of sync. Hopefully that should improve the UI build.

Tested with mvn clean test install -Pdev, no changes to yarn.lock, build passed OK.

@kinow
Copy link
Member Author

kinow commented Jan 25, 2022

@afs I had a look at ASF's Jenkins, but the Test Development job appears to be polling the main branch periodically. Do we have a job somewhere that will run for this pull request? Or is it triggered only after things are merged? Thanks!

@afs
Copy link
Member

afs commented Jan 25, 2022

We don't have a Jenkins run to run PR branches. We "merge then test" :-). The Test Development job is running mvn clean verify (test will happen) and hopefully people do that before sending the PR. We don't have build steps outside maven; if we did, then we'd probably need a PR-runner. Lots of jobs on Jenkins is good ... except for the unnecessary power costs.

I'll pull the branch:

ID=...number...
NEWBRANCH=...local name...
git fetch upstream pull/$ID/head:$NEWBRANCH
git co "$NEWBRANCH"

@afs
Copy link
Member

afs commented Jan 25, 2022

... ran twice, yarn.lock is stable.

@kinow kinow merged commit 40c0bb8 into apache:main Jan 25, 2022
@kinow
Copy link
Member Author

kinow commented Jan 25, 2022

Thanks!

@kinow kinow deleted the upgrade-yarn branch January 25, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants