Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jena 1206 #149

Merged
merged 9 commits into from Jul 14, 2016
Merged

Jena 1206 #149

merged 9 commits into from Jul 14, 2016

Conversation

barthanssens
Copy link
Contributor

Added W3C DCAT, VoID, ORG and ROV vocabularies

Signed-off-by:Bart Hanssens <bart.hanssens@fedict.be>
Signed-off-by:Bart Hanssens <bart.hanssens@fedict.be>
Signed-off-by:Bart Hanssens <bart.hanssens@fedict.be>
Signed-off-by:Bart Hanssens <bart.hanssens@fedict.be>
Signed-off-by:Bart Hanssens <bart.hanssens@fedict.be>
@afs
Copy link
Member

afs commented Jul 9, 2016

+1 : Looks good to me.

Signed-off-by:Bart Hanssens <bart.hanssens@fedict.be>
Signed-off-by:Bart Hanssens <bart.hanssens@fedict.be>
@afs
Copy link
Member

afs commented Jul 11, 2016

I was assuming these vocabularies would be part of the main distribution and build. If so, the POM file is not needed (nor invoked).

@afs
Copy link
Member

afs commented Jul 11, 2016

If we were starting from scratch, vocabularies/w3c makes sense. We already have RDF, RDFS, OWL, SKOS which are W3C vocabularies and they are in vocabularies/.

@barthanssens
Copy link
Contributor Author

Ah OK, so should I go back to the original proposal (just adding the classes to ...vocabularies), or use a separate package (as suggested in https://issues.apache.org/jira/browse/JENA-1206, e.g. "vocabularies.egov") ? Thanks.

@afs
Copy link
Member

afs commented Jul 12, 2016

I don't have any strong feelings - I'm just following the current pattern (for better or worse).

I doubt we will have name clashes (independent vocabs - not versions).

The minor downside of classifying by package is implicit domain. DCAT will be hopefully used much more widely than eGov.

Bart.Hanssens added 2 commits July 14, 2016 09:12
…ens <bart.hanssens@fedict.be>"

This reverts commit 0f1c967.
…bart.hanssens@fedict.be>"

This reverts commit 96f7b15.
@asfgit asfgit merged commit d11b5c8 into apache:master Jul 14, 2016
asfgit pushed a commit that referenced this pull request Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants