Using library code in a few classes #171
Conversation
|
Given PR #139 in-progress, can we hold back on the JSON-LD changes for now? |
| @@ -32,52 +38,35 @@ | |||
| return rand(numRand, low, high, false) ; | |||
| } | |||
|
|
|||
| /** Generate a random sequence between low (inclusive) and high (exclusive) - choose whether to have duplicates or not */ | |||
| /** | |||
| * Generate a random sequence between low (inclusive) and high (exclusive) - with duplicates or no | |||
| @@ -95,19 +84,13 @@ | |||
| } | |||
| if ( !found ) | |||
| System.err.printf("Corrupted permute: [%s] [%s]\n", strings(x), strings(x2)) ; | |||
| } | |||
| }*/ | |||
There was a problem hiding this comment.
Delete commented out code? (we have git!)
|
Yes, certainly I'll hold off-- I have no idea how I missed that, especially given that I just pointed out that JSON-LD PR to a colleague in a downstream project yesterday! |
| @@ -23,7 +23,6 @@ | |||
| import java.io.OutputStreamWriter ; | |||
| else | ||
| JsonUtils.write(writer, obj) ; | ||
| if ( isPretty() ) JsonUtils.writePrettyPrint(writer, obj) ; | ||
| else JsonUtils.write(writer, obj) ; |
There was a problem hiding this comment.
I don't like if statements with their positive clause on the same line unless they have no else clause and are not part of the flow of the logic. (e.g. not part of the flow: if ( DEBUG) System.err.println(....) ;)
| Node pred = t.getPredicate(); | ||
| return pred.equals(RDF.type.asNode()) || ctx.containsKey(pred.getLocalName()); | ||
| }) | ||
| .forEachRemaining(addToContext) ; | ||
| } |
There was a problem hiding this comment.
I think it was clearer to have the if ( p.equals(RDF.type.asNode()) ) in teh Consumer because all the logic is in one place.
|
Now that we have #139 in, I'll add a further commit addressing your points. Thanks! |
ajs6f
force-pushed
the
JsonLDWriterJava8Stuff
branch
from
2b9f041
to
23cac4c
Compare
|
Made changes in response to your review, @afs . If you have no further objections, I'll merge this. |
ajs6f
force-pushed
the
JsonLDWriterJava8Stuff
branch
from
23cac4c
to
b6d0f61
Compare
Just a couple of orthogonal commits that use library code in
Collections, switch to usingdefaultmethods where it seems appropriate, remove assignments with no effect, that sort of thing. If no one has any objection within a couple of days, I'll merge it myself.