GH-2102: Parse and accept [], with warning #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afs
force-pushed
the
gh2102-sparql-iri
branch
from
99d85f7
to
f6969b9
Compare
|
Best reviewed in the Github UI with "hide whitepace". |
kinow
reviewed
Dec 1, 2023
There was a problem hiding this comment.
Is it currently testing that if ( iriStr.contains(" ") ) {? I thought we would need an IRI with space(s), but I didn't find it in this test. The rest looks good.
afs
force-pushed
the
gh2102-sparql-iri
branch
from
f6969b9
to
30f6c57
Compare
afs
force-pushed
the
gh2102-sparql-iri
branch
from
30f6c57
to
0466550
Compare
|
Tests added because "why not?"
The way the SPARQL grammar is written is to have a token rule that excludes impossible characters, then expect detailed checking.
|
kinow
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #2102. This closes #2102.
Pull request Description:
This change causes the parser to accept, with a warning, the charcater
[and].This makes it behave the same as RIOT data syntax parsing.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.