Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JENA-1309: HttpOp should respect system properties for default client #223

Closed
wants to merge 1 commit into from
Closed

JENA-1309: HttpOp should respect system properties for default client #223

wants to merge 1 commit into from

Conversation

ajs6f
Copy link
Member

@ajs6f ajs6f commented Mar 9, 2017

No description provided.

afs
afs approved these changes Mar 9, 2017
View reviewed changes
Copy link
Member

@afs afs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HttpClient code is twisty but I think this gets to SystemDefaultRoutePlanner and does the right thing.

@ajs6f
Copy link
Member Author

ajs6f commented Mar 9, 2017

Yeah, HttpOp is usually my first stop for this kind of thing because my understanding is that in theory, all ARQ routes all HTTP traffic through HttpOp.

@afs
Copy link
Member

afs commented Apr 1, 2017

Status?

@ajs6f
Copy link
Member Author

ajs6f commented Apr 2, 2017

I was waiting to hear confirmation from the reporter that this is a fix, but it's been quite a while. I have no prob with merging this as-is.

@ajs6f
Copy link
Member Author

ajs6f commented Apr 4, 2017

Fixed with https://git-wip-us.apache.org/repos/asf?p=jena.git;a=commit;h=711e9be838efdb056bfa4bccc253c58799affea0

@ajs6f ajs6f closed this Apr 4, 2017
@ajs6f ajs6f deleted the JENA-1309 branch April 4, 2017 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afs afs afs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs6f @afs