JENA-1321: Exception rewrapping in HttpQuery masks error response from the server #241
Conversation
|
@rmorrise, will this suit you? |
|
Code looks good! I am new to git, but if I understood correctly, you took my change plus adding the responseCode, but did not take my changes to TestService. I think this will fail the unit tests? Please correct me if I am reading the diff wrong. Do I need to do anything for the changes to be applied to the main repo? |
|
No, actually, I did not start with your code-- if you look at what I did, I added fields and accessors and a constructor to |
|
The tests pass fine, because as @afs prescribed, we aren't changing the wrapping of exceptions, just adding useful information to "outer" ones. |
|
My mistake! I didn't notice the call to httpEx.getCause() in the constructor. |
| public String getResponse() { return response ; } | ||
|
|
||
| /** The status line for the response for this exception | ||
| * @return status line |
There was a problem hiding this comment.
"The status line for the response if available from HTTP"
| * @return message | ||
| */ | ||
| public String getResponseMessage() { return responseMessage ; } | ||
|
|
||
| /** The response for this exception | ||
| * @return response |
There was a problem hiding this comment.
Note that this can be null if the original exception was not from the HTTP protocol, but from e.g. an IOException why doing an HTTP operation.
"The response for this exception if available from HTTP"
It's a bit odd-feeling to couple
HttpExceptionso tightly, but given that it is an Atlas type, I don't feel terrible about it.