Cleanup #407
Merged
Cleanup #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvesse
reviewed
Apr 24, 2018
| @@ -111,7 +112,8 @@ public Graph getDefaultGraph() { | |||
|
|
|||
| @Override | |||
| public Graph getGraph(Node gn) { | |||
| return ngCache.getOrFill(gn, ()->GraphViewSwitchable.createNamedGraph(this, gn)); | |||
| Node key = ( gn != null ) ? gn : Quad.defaultGraphNodeGenerated; | |||
| return ngCache.getOrFill(gn, ()->GraphViewSwitchable.createNamedGraph(this, key)); | |||
There was a problem hiding this comment.
Shouldn't the first gn reference on this line also be changed to key otherwise you are adding a potentially null key to the cache
There was a problem hiding this comment.
Yes, doh! Thanks for spotting that.
kinow
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of small things noticed while investigating a TDB2 report.
Includes tweak for JENA-1428 (cleanup) and fix for JENA-1531.