JENA-1560: PrefixMappingUtils #432
Conversation
| * Analyse the graph to see which prefixes of the graph are in use. | ||
| * <p> | ||
| * In the case of overlapping prefixes (where one prefix declaration is has an initial | ||
| * URI string which imatches another prefix declaration), all are included, though |
| * use. | ||
| * <p> | ||
| * In the case of overlapping prefixes (where one prefix declaration is has an initial | ||
| * URI string which imatches another prefix declaration), all are included, though |
|
|
||
| // Map URI to prefix, with partial lookup (all uri keys that partly match the URI) | ||
| Trie<String> trie = new Trie<>() ; | ||
| // Chnage this to "add(uri, uri)" to calculate the uris. |
| String uri = node.getURI() ; | ||
| // Get all prefixes whose URIs are candidates | ||
| List<String> hits = trie.partialSearch(uri) ; | ||
| if ( hits == null || hits.isEmpty() ) |
There was a problem hiding this comment.
I think partialSearch never returns null, but harmless to leave the check here.
|
Thanks - all review points done. I amended to PR to keep it to one commit. |
| * <p> | ||
| * The prefix mappings of the two graphs are not connected. | ||
| * Later changes to the prefix mapping of the original graph are not reflected in the returned graph. | ||
| * Modifications to the triples conatained in the underlying graph are reflected. |
| public class PrefixMappingUtils { | ||
| /** | ||
| * Return a read-only graph that has the same data (RDF triples) as the one given, but has a | ||
| * prefix mapping that only includes "in use " prefixes. |
There was a problem hiding this comment.
Might want to put a link here to calcInUsePrefixMapping below just in case someone wants to the precise meaning of "in use".
| * | ||
| * @see #calcInUsePrefixMapping(Graph, PrefixMapping) | ||
| */ | ||
| public static PrefixMapping calcInUsePrefixMappingTTL(Graph graph, PrefixMapping prefixMapping) { |
There was a problem hiding this comment.
Maybe leave a TODO to factor out common logic between this and calcInUsePrefixMapping?
|
|
||
| // Get all under the pref | ||
| List<String> hits = trie.partialSearch(pref) ; | ||
| if ( hits == null || hits.isEmpty() ) |
There was a problem hiding this comment.
Looking at Trie::partialSearch, I don't think hits can be null here. I guess why you don't check for null above?
| // inUse.add(ns) ; | ||
| } | ||
|
|
||
| private static void print(Set<String> inUsePrefixURIs, PrefixMapping prefixMapping) { |
There was a problem hiding this comment.
Should we leave this in? It looks like debugging code?
There was a problem hiding this comment.
The algorithm took a while to get right and being about to print the state was useful. I'll add a comment that's it for development assistance. Maybe it will never needed.
There was a problem hiding this comment.
The algorithm took a while to get right and being about to print the state was useful. I'll add a comment that's it for development assistance. Maybe it will never needed.
Some utility code that can be useful.