JENA-1481, JENA-1586: Delete databases and expel from JVM #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajs6f
reviewed
Aug 10, 2018
| public static void deleteAll(Path start) { | ||
| // Walks down the tree and deletes directories on the way backup. | ||
| try { | ||
| Files.walkFileTree(start, new SimpleFileVisitor<Path>() { |
There was a problem hiding this comment.
Could this new SimpleFileVisitor be broken out as a static inner class?
There was a problem hiding this comment.
Could do though I prefer to put the action code near to its usage, all in the method. (It is also an idiom (e.g. stackoverflow) to inline the visitor.)
There was a problem hiding this comment.
I'm not worried about it. I'm always a bit suspicious on anon inner classes because of the occasional GC problems, but I think I'm letting my suspicions run away from me.
| action.log.info(format("[%d] Deleted database files %s", action.id, pDatabase)) ; | ||
| } | ||
| } catch (RuntimeIOException e) { | ||
| e.printStackTrace(); |
kinow
approved these changes
Aug 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.