JENA-904 Avoid activeInterpreters leak #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safest to call child.close() before your own super.close
.. so that it is removed from activeInterpreters calling .setComplete() on the other hand broke other tests as it closes too much too early
|
You might notice the test is very similar to #44 - but I kept it in a separate file here now to avoid merge conflicts. Feel free to manually merge the two tests! |
|
Anything blocking this fix..? It does not depend on #44, although both must go in to solve JENA-904. |
Aklakan
referenced
this pull request
in Aklakan/jena
Oct 3, 2022
Altered DynamicDataset for From-As-Filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JENA-904 by closing the interpreter of the generator of /ConsumerChoicePointFrame - and making sure CCPF.close() is called through super.close() calls of its owners.