JENA-1642: Check has value for header instead of is true #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, I'm afraid it is. Some tests fail when used with Apache parent >19 (I just checked with v21 - this is still the case). |
afs
approved these changes
Nov 29, 2018
asfgit
pushed a commit
that referenced
this pull request
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using schemagen from the maven plugin the
headeroption does not work.headeris intended to be a template string and whenisTrueis checked the string is cast to a boolean and theBadBooleanExceptionis thrown. I believe we should check for existence here instead of "truthiness"Also, it appears that the maven tools are no being built as part of the main project. Is that the case?