Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENA-1756: Dependency updates #603

Merged
merged 2 commits into from Sep 12, 2019
Merged

JENA-1756: Dependency updates #603

merged 2 commits into from Sep 12, 2019

Conversation

afs
Copy link
Member

@afs afs commented Sep 11, 2019

No description provided.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency updates look good. Bit rusty with Java8+ time, but found nothing that seems wrong. 👍

private static final FastDateFormat timeFmt_XSD_ms0 = FastDateFormat.getInstance("HH:mm:ssZZ") ;
// For milliseconds != 0
private static final FastDateFormat timeFmt_XSD_ms = FastDateFormat.getInstance("HH:mm:ss.SSSZZ") ;
// Use xxx to get +00:00 format with DateTimeFormatter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, didn't know about xxx for the time-zone offset. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nor did I until a few hours ago!

@afs afs merged commit 110309f into apache:master Sep 12, 2019
@afs afs deleted the dependency-updates branch September 12, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants