JENA-2031: Refine IRI settings #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
approved these changes
Mar 1, 2021
| @@ -291,6 +293,14 @@ public RDFParserBuilder httpClient(HttpClient httpClient) { | |||
| */ | |||
| public RDFParserBuilder resolveURIs(boolean flag) { this.resolveURIs = flag ; return this; } | |||
|
|
|||
| /** | |||
| * Provide a specific {@link IRIxResolver} to check and resolve URIs. It's | |||
|
|
||
| // Whitespace. | ||
| // XSD allows whitespace before and after the lexical forms of a literal but not | ||
| // insiode. |
| private static IRIx setSystemBase(String baseStr) { | ||
| /** | ||
| * Create an {@link IRIx} suitable for a system base. | ||
| * This oepration always returns an {@link IRIx} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work inspired by parsing wikidata with Jena3, finding all the types of warnings and errors that arise then making the new code agree with Jena3, except where newer RFCs have changed the situation (e.g. percent encoding in DNS host names is now legal). The code also reflect jena's behaviour of warning about bad IRIs but not signalling a parse error - very large datasets have some less-than-perfect IRIs in them and aborting a load because of this is annoying.
Tests added to pin down expectations.
There is also a lot of clearing up and refactoring.
Performance checked: the Jena3 and Jena4 times to parse (BSBM data) are the same.
Hopefully, the last large IRI-related PR!