Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Proxy server use labels english for HTTP Header Manager and Response Assertion #2183

Closed
asfimport opened this issue Dec 20, 2008 · 2 comments

Comments

@asfimport
Copy link
Collaborator

@milamberspace (Bug 46423):
HTTP Proxy server use labels english for HTTP Header Manager and Response Assertion when 'Capture HTTP headers' and 'Add Assertions' are check
There aren't i18n labels

OS: Linux

@asfimport
Copy link
Collaborator Author

@milamberspace (migrated from Bugzilla):
Created attachment patch_46423.txt: Proposal patch

patch_46423.txt
Index: /Workspaces-JMeter/Jmeter/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java
===================================================================
--- /Workspaces-JMeter/Jmeter/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java	(revision 728228)
+++ /Workspaces-JMeter/Jmeter/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java	(working copy)
@@ -235,7 +235,7 @@
         }
     }
 
-    public String getClassLabel() {
+    public static String getClassLabel() {
         return JMeterUtils.getResString("header_manager_title");// $NON-NLS-1$
     }
 
Index: /Workspaces-JMeter/Jmeter/src/protocol/http/org/apache/jmeter/protocol/http/proxy/HttpRequestHdr.java
===================================================================
--- /Workspaces-JMeter/Jmeter/src/protocol/http/org/apache/jmeter/protocol/http/proxy/HttpRequestHdr.java	(revision 728228)
+++ /Workspaces-JMeter/Jmeter/src/protocol/http/org/apache/jmeter/protocol/http/proxy/HttpRequestHdr.java	(working copy)
@@ -244,7 +244,7 @@
                 manager.add((Header) headers.get(key));
             }
         }
-        manager.setName("Browser-derived headers");
+        manager.setName(HeaderManager.getClassLabel());
         manager.setProperty(TestElement.TEST_CLASS, HeaderManager.class.getName());
         manager.setProperty(TestElement.GUI_CLASS, HeaderPanel.class.getName());
         return manager;
Index: /Workspaces-JMeter/Jmeter/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
===================================================================
--- /Workspaces-JMeter/Jmeter/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java	(revision 728228)
+++ /Workspaces-JMeter/Jmeter/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java	(working copy)
@@ -514,7 +514,7 @@
     private void addAssertion(JMeterTreeModel model, JMeterTreeNode node) throws IllegalUserActionException {
         ResponseAssertion ra = new ResponseAssertion();
         ra.setProperty(TestElement.GUI_CLASS, ASSERTION_GUI);
-        ra.setName("Check response");
+        ra.setName(JMeterUtils.getResString(new AssertionGui().getLabelResource()));
         ra.setTestFieldResponseData();
         model.addComponent(ra, node);
     }

@asfimport
Copy link
Collaborator Author

Sebb (migrated from Bugzilla):
Thanks, fixed in

URL: http://svn.apache.org/viewvc?rev=730650&view=rev
Log:
#2183 - I18N of Proxy Recorder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant