Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPSampler2 response timeout not honored #2245

Closed
asfimport opened this issue Jun 5, 2009 · 2 comments
Closed

HTTPSampler2 response timeout not honored #2245

asfimport opened this issue Jun 5, 2009 · 2 comments

Comments

@asfimport
Copy link
Collaborator

Ridai Govinda Pombo (Bug 47321):
Trying out the new HTTPSampler timeout configurations, I've noticed that the response timeout wasn't being read somehow. It ALWAYS timed out. Connect timeout worked correctly.

At org.apache.jmeter.protocolo.http.sampler.HTTPSampler2.java, line 574:

   int rto = getResponseTimeout();
    if (rto > 0){
        httpMethod.getParams().setSoTimeout(1);
    }

Reading the Java Socket documentation, the setSoTimeout understands miliseconds! I just replaced to:

   int rto = getResponseTimeout();
    if (rto > 0){
        httpMethod.getParams().setSoTimeout(rto);
    }

Recompiled jmeter-2.3.3 and now it works correctly.

Severity: major
OS: Linux

@asfimport
Copy link
Collaborator Author

Ridai Govinda Pombo (migrated from Bugzilla):
Created attachment jakarta-jmeter-2.3.3-timeout.patch.bz2: HTTPSampler2.java modification

@asfimport
Copy link
Collaborator Author

Sebb (migrated from Bugzilla):
Oops! That was temporary test code that should have been replaced.

Thanks for the report; fixed in:

URL: http://svn.apache.org/viewvc?rev=783174&view=rev
Log:
#2245 - HTTPSampler2 response timeout not honored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant