JMS support for durable subscriptions

[asfimport]

Christoph Jahn (Bug 50666):
Here is a patch that adds support for durable subscriptions to the JMS Subscriber Sampler.

It was created against trunk as of yesterday morning (revision 1063734).

This is my very first contribution of this kind, and although I have spent quite some time going through various documentation, I may well have missed some guideline.

Created attachment JMeter_JMS_DurableSubscription.patch: Patch to support durable subscriptions to JMS Subscriber Sampler

OS: All

[asfimport]

Sebb (migrated from Bugzilla):
Thanks!

Patch looks generally OK from a visual inspection.

It would be helpful to also have a patch for the documentation, i.e. component_reference.xml, which explains what the new field does.

BTW, the getProperty() and setProperty() methods have versions which provide defaults. The get default can be used to ensure the value is not null.
The set default is useful to ensure that the property is not added to JMX files if it is empty. Obviously the same defaults must be used!

We try to use this for new properties, otherwise the JMX files keep growing.

No need to update the patch - that can be fixed later.

[asfimport]

Christoph Jahn (migrated from Bugzilla):
Revised patch:

• updated component_reference.xml
• uses setProperty() with default

Created attachment JMeter_JMS_DurableSubscription.patch: Patch to support durable subscriptions to JMS Subscriber Sampler

[asfimport]

Christoph Jahn (migrated from Bugzilla):
Shows the "Durable Subscription ID" field

Created attachment jmssubscriber.png: Screenshot of JMS Subscriber sampler

[asfimport]

Sebb (migrated from Bugzilla):
(In reply to comment 2)

Created an attachment (id=26573) [details]
Patch to support durable subscriptions to JMS Subscriber Sampler

Revised patch:

• updated component_reference.xml
• uses setProperty() with default

The patch file is identical to the previous one - wrong file attached?

[asfimport]

Christoph Jahn (migrated from Bugzilla):
Sorry for the mess and the delay. This patch should hopefully be ok now

Created attachment JMeter_JMS_DurableSubscription.patch-3.txt: Patch to support durable subscriptions to JMS Subscriber Sampler (v3)

[asfimport]

Sebb (migrated from Bugzilla):
Thanks, the patch fixes the JMX file defaults.

Still no sign of a patch for component_reference.xml however.

If you have done the work, please attach a separate patch containing just that.

[asfimport]

Christoph Jahn (migrated from Bugzilla):
And here the missing component_reference.xml. Thanks for catching that!

Created attachment JMeter_JMS_DurableSubscription_comp-ref-xml.patch.txt: Addendum to patch v3 with component_reference.xml

JMeter_JMS_DurableSubscription_comp-ref-xml.patch.txt

Index: xdocs/usermanual/component_reference.xml
===================================================================
--- xdocs/usermanual/component_reference.xml	(revision 1082821)
+++ xdocs/usermanual/component_reference.xml	(working copy)
@@ -1236,6 +1236,8 @@
   <property name="JNDI Initial Context Factory" required="No">Name of the context factory</property>
   <property name="Provider URL" required="No">The URL for the jms provider</property>
   <property name="Destination" required="Yes">the message destination (topic or queue name)</property>
+  <property name="Durable Subscription ID" required="No">The ID to use for a durable subscription. On first 
+  use the respective queue will automatically be generated by the JMS provider if it does not exist yet.</property>
   <property name="Setup" required="Yes">The destination setup type. With At startup, the destination name is static (i.e. always same name during the test), with Each sample, the destination name is dynamic and is evaluate at each sample (i.e. the destination name may be a variable)</property>
   <property name="Authentication" required="Yes">Authentication requirement for the JMS provider</property>
   <property name="User" required="No">User Name</property>

[asfimport]

Sebb (migrated from Bugzilla):
Thanks, committed:

URL: http://svn.apache.org/viewvc?rev=1082871&view=rev
Log:
#2459 - JMSSubscriber: support for durable subscriptions