HTTP Cache is broken when using "Retrieve all embedded resources" with concurrent pool

[asfimport]

shmulikk (Bug 51752):
HTTP Cache is working fine for HTTP Request Sampler and for all of the embedded resources.
When enabling concurrent thread pool for "Retrieve all embedded resources" the requests are being sent without the relevant cache headers.

Probably got to do with the cache info being saved on the requesting thread which probably exits after getting all embedded resources (this is occurring also with only one thread in the concurrent thread pool).

This happens with any HttpClient or JAVAImpl.

Severity: normal
OS: All

Blocks:

• OutOfMemoryError remote testing with HTTPClient HC4 and JMeter 2.5 #2568

[asfimport]

shmulikk (migrated from Bugzilla):
Caused by current implementation of CacheManager, which using ThreadLocal to separate Cache for each thread(virtual user).

This is causing to separate the Cache to each thread in the concurrent pool, thus breaking the cache.

Currently in CacheManager.java:
private transient ThreadLocal<Map<String, CacheEntry>> threadCache;

Suggested solution:
Removing ThreadLocal from the code.
Changing the key to include the url (current key) + ThreadName.

[asfimport]

@milamberspace (migrated from Bugzilla):
Good catch. Thanks for report.
Fixed with InheritableThreadLocal (concurrent threads pool are chlidren of main http request/virtual user)

URL: http://svn.apache.org/viewvc?rev=1166165&view=rev
Log:
#2523 - HTTP Cache is broken when using "Retrieve all embedded resources" with concurrent pool

Modified:
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java
jakarta/jmeter/trunk/xdocs/changes.xml

[asfimport]

@milamberspace (migrated from Bugzilla):
Not good. Don't works with several loops (works only on same loop for same embebbed resources)

Need some additionnal works

[asfimport]

@milamberspace (migrated from Bugzilla):
Oups !!!
Works with loops, I forget to unchecked "Clear cache each iteration?" on HTTP Cache manager on my test plan.

Sorry from SPAM.