Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionnality to search in Samplers TreeView #2559

Closed
asfimport opened this issue Sep 22, 2011 · 13 comments
Closed

Functionnality to search in Samplers TreeView #2559

asfimport opened this issue Sep 22, 2011 · 13 comments

Comments

@asfimport
Copy link
Collaborator

@pmouawad (Bug 51876):
Hello,
It would be very useful during Test creation to have a functionnality to search in the TreeView to Samplers that:

  • Contains some text in query or in query parameters
  • Contains some text in response
  • Contain a certains HTTP Header Manager with some content type (to search for all GWT queries for example, or all text/png queries)
  • ....

Node that fill these conditions would be highlighted or background color changed.

Regards
Philippe

OS: All

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Hello,
I have implemented the start of this feature.
For now it only allows searching HTTPSampler but it is supposed to be extensible to any sampler by making it implement Searchable.

I also plan to enhance search dialog and search features.
But I would like to have your first comments on it and critics.

It would be great if it can be integrated in next release because I find it useful.

Regards
Philippe Mouawad

Created attachment ISSUE_51876.patch: First Implementation

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
ScreenShot of Search dialog

Created attachment search.png: Search Popup

Search Popup

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Result of search, nodes have a red border.

Created attachment result.png: Result of a search

Result of a search

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Created attachment Capture d’écran 2011-09-28 à 12.45.42.png: Search Menu

Search Menu

@asfimport
Copy link
Collaborator Author

Sebb (migrated from Bugzilla):
The new Searchable.java file needs the standard AL header, but otherwise patch looks OK.

Also need to update the docs - component_reference.xml

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Date: Tue Oct 11 17:32:43 2011
New Revision: 1181906

URL: http://svn.apache.org/viewvc?rev=1181906&view=rev
Log:
#2559 - Functionnality to search in Samplers TreeView

Added:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/Searchable.java (with props)
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeCommand.java (with props)
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/ActionNames.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterCellRenderer.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeNode.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
jakarta/jmeter/trunk/xdocs/changes.xml
jakarta/jmeter/trunk/xdocs/usermanual/hints_and_tips.xml

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
New Revision: 1182051

URL: http://svn.apache.org/viewvc?rev=1182051&view=rev
Log:
#2559 - Functionnality to search in Samplers TreeView

Highlight all nodes up to ThreadGroup node to make search result visible if nodes are not expanded

Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeCommand.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeNode.java

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Date: Tue Oct 11 20:01:55 2011
New Revision: 1182059

URL: http://svn.apache.org/viewvc?rev=1182059&view=rev
Log:
#2559 - Functionnality to search in Samplers TreeView

Factored in AbstractTestElement method testField.
Implemented search for BeanShellPostProcessor, RegexExtractor, XPathExtractor

Modified:
jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/BeanShellPostProcessor.java
jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/RegexExtractor.java
jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/XPathExtractor.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/AbstractTestElement.java
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Date: Wed Oct 12 10:40:53 2011
New Revision: 1182305

URL: http://svn.apache.org/viewvc?rev=1182305&view=rev
Log:
#2559 - Functionnality to search in Samplers TreeView
Fixed issue with empty search and no reset of previous search results

Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeCommand.java

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Date: Wed Oct 12 17:14:12 2011
New Revision: 1182483

URL: http://svn.apache.org/viewvc?rev=1182483&view=rev
Log:
#2559 - Functionnality to search in Samplers TreeView

Enable search on TransactionController

Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/control/TransactionController.java

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Date: Wed Oct 12 17:22:07 2011
New Revision: 1182485

URL: http://svn.apache.org/viewvc?rev=1182485&view=rev
Log:
#2559 - Functionnality to search in Samplers TreeView

Added reset search
Used reset search in search
Handled cancelation of search

Added:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/ResetSearchCommand.java (with props)
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/ActionNames.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeCommand.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Date: Thu Oct 13 17:23:58 2011
New Revision: 1182997

URL: http://svn.apache.org/viewvc?rev=1182997&view=rev
Log:
#2559 - Functionnality to search in Samplers TreeView

Implemented search in AbstractTestElement and refactored already implemented subclasses to use ancestor method.
Added search features on additionnal configuration elements to:

  • BeanShellTestElement
  • AbstractScopedElement
  • CSVDataSet

Also enabled search up to Test Plan node.

Modified:
jakarta/jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSet.java
jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/BeanShellPostProcessor.java
jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/RegexExtractor.java
jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/XPathExtractor.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/control/TransactionController.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeNode.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/AbstractScopedTestElement.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/testelement/AbstractTestElement.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellTestElement.java
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Date: Fri Nov 4 08:34:07 2011
New Revision: 1197425

URL: http://svn.apache.org/viewvc?rev=1197425&view=rev
Log:
#2559 - Functionnality to search in Samplers TreeView
Changed implementation to:

  • Add ability to search with regexp
  • Add ability to search in case sensitive and insentive modes
  • Plug additional search implementations

Added:
jmeter/trunk/src/core/org/apache/jmeter/gui/action/RawTextSearcher.java (with props)
jmeter/trunk/src/core/org/apache/jmeter/gui/action/RegexpSearcher.java (with props)
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeDialog.java (with props)
jmeter/trunk/src/core/org/apache/jmeter/gui/action/Searcher.java (with props)
Modified:
jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSet.java
jmeter/trunk/src/components/org/apache/jmeter/extractor/RegexExtractor.java
jmeter/trunk/src/components/org/apache/jmeter/extractor/XPathExtractor.java
jmeter/trunk/src/core/org/apache/jmeter/gui/Searchable.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeCommand.java
jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
jmeter/trunk/src/core/org/apache/jmeter/testelement/AbstractScopedTestElement.java
jmeter/trunk/src/core/org/apache/jmeter/testelement/AbstractTestElement.java
jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellTestElement.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant