Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With next-Loop-On-Error after error samples are not executed in next loop #2678

Closed
asfimport opened this issue Dec 14, 2011 · 6 comments
Closed

Comments

@asfimport
Copy link
Collaborator

bernd.lemmer (Bug 52330):
The new feature of 2.5 next-Loop-On-Error (#1422 ) is a very very useful one!
Thank you a lot for that. I tried it immediately, thereby I recognized two little problems:
First:
When the thread group starts with an only-once-controller, it doesn't work well.
Please see <<Thread Group 4b - works not>> for demo.
Second:
When the error occurs in the last sample of the thread group, in the next loop only the
transaction controller and not the samplers are listed in the view result tree as been executed.
Please see <<Thread Group 4e - works not>> for demo

Created attachment nextLoopOnError.zip: testplan an log

Severity: normal
OS: All

@asfimport
Copy link
Collaborator Author

bernd.lemmer (migrated from Bugzilla):
Step to Reproduce:
Run the testplan in the attachments.
The testplan is based on <<Test_cases30563.jmx>>
Actual Results:
After an error occurred, in the next loop only the transaction controller is processed but not any sampler.
Expected Results:
In the next loop after an error occurred, all samplers should be executed. You can see this by disabling the only-once-controller.
If or if not an error occurred in the previous loop should not modify the execution sequence of the actual loop.
Build Date & Platform:
Version 2.5 r1158837
java.version=1.6.0_29
Please see attached logfile

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Hello,
Feature has completely been rewritten in Trunk version.
I checked your Test plan and cannot reproduce isses using Trunk Version.

You can get nightly build here to test on your side:
https://builds.apache.org/job/JMeter-trunk/lastSuccessfulBuild/artifact/trunk/dist/

Get :
apache-jmeter-r1214179_bin.tgz
apache-jmeter-r1214179_lib.tgz

And unzip both then copy lib content into lib folder.

Regards
Philippe
http://www.ubik-ingenierie.com

This bug has been marked as a duplicate of #2556

@asfimport
Copy link
Collaborator Author

bernd.lemmer (migrated from Bugzilla):
Hello,
thank you for your answer.
After download the trunk version I saw that the first problem is fixed and works well.
But ...
The second problem, demonstrated in thread group <<Thread Group 4e - works not>> is not yet fixed in my opinion:
If the error occurs in the last sample of the threadgroup, then every second loop is missed. If the loopcount is 3 or 4, then two loops are executed. If the loopcount is 5, then 3 loops are processed.

I hope, you will be able to reproduce the problem too, if you modify the loopcount of the threadgroup.

Regards,
Bernd

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Created attachment Test_nextLoopOnError.jmx: More complete Test Case

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Date: Sat Dec 17 23:08:55 2011
New Revision: 1220300

URL: http://svn.apache.org/viewvc?rev=1220300&view=rev
Log:
#2678 - With next-Loop-On-Error after error samples are not executed in next loop

Modified:
jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterThread.java
jmeter/trunk/xdocs/changes.xml

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Hello M. Lemmer,
Thank you for your tests, I reproduced issue.

I think now all cases are fixed, but please take some time to check it works for you and reopen issue if you find there is still a problem.

Regards
Philippe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant