Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI : Allow Popups to be closed with ESC key #2930

Closed
asfimport opened this issue Sep 16, 2012 · 3 comments
Closed

GUI : Allow Popups to be closed with ESC key #2930

asfimport opened this issue Sep 16, 2012 · 3 comments

Comments

@asfimport
Copy link
Collaborator

@pmouawad (Bug 53879):
Not all popups (JDialog) in JMeter can be closed by ESC key which brings better UI experience

Severity: minor
OS: All

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Concerned Dialogs:

  • Function Helper Dialog
  • About
  • Help

Use more up to date method to do so for existing ones:

  • Search feature
  • Row Detail

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Date: Sun Sep 16 10:06:30 2012
New Revision: 1385239

URL: http://svn.apache.org/viewvc?rev=1385239&view=rev
Log:
#2930 - GUI : Allow Popups to be closed with ESC key
#2930

Added:
jmeter/trunk/src/core/org/apache/jmeter/gui/util/EscapeDialog.java (with props)
Modified:
jmeter/trunk/src/core/org/apache/jmeter/config/gui/RowDetailDialog.java
jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
jmeter/trunk/src/core/org/apache/jmeter/gui/MainFrame.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/AboutCommand.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/Help.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeDialog.java
jmeter/trunk/xdocs/changes.xml

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Date: Mon Sep 17 20:08:45 2012
New Revision: 1386800

URL: http://svn.apache.org/viewvc?rev=1386800&view=rev
Log:
#2930 - GUI : Allow Popups to be closed with ESC key

Use String as less as possible
#2930

Modified:
jmeter/trunk/src/core/org/apache/jmeter/config/gui/RowDetailDialog.java
jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeDialog.java
jmeter/trunk/src/core/org/apache/jmeter/gui/util/EscapeDialog.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant