Test Action regression, duration value is not recorded

[asfimport]

@milamberspace (Bug 55027):
With last svn trunk, the field 'Duration' isn't record/save his value after click on another element in the tree.
(not works with Linux and jdk6|7 and Win7 and jdk7)

With 2.9, works fine.

Version: Nightly
OS: All

Blocks:

• why does the focus listener now get called after modifyTestElement? #3144

[asfimport]

@milamberspace (migrated from Bugzilla):

If you insert a value in Duration field, click on Stop radio button, click outside Test action element (for example Test Plan), return to Test Action element, click on Pause radio button, then it's work...

[asfimport]

Sebb (migrated from Bugzilla):
AFAICT, this regression was caused by something external to TestAction and its GUI class, as those have not changed.

The problem seems to be that modifyTestElement is now called before the focus listener saves the new value.

This could potentially affect other GUIs.

[asfimport]

@milamberspace (migrated from Bugzilla):
The issue was introduce by his commit (works before, not after)

Author: pmouawad
Date: Wed Apr 17 20:16:53 2013
New Revision: 1469057

URL: http://svn.apache.org/r1469057
Log:
#3096 - Improve Drag & Drop in the jmeter tree
#3096

Added:
jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeTransferHandler.java (with props)
Removed:
jmeter/trunk/src/core/org/apache/jmeter/gui/action/DragNDrop.java
Modified:
jmeter/trunk/src/core/org/apache/jmeter/gui/MainFrame.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/ActionNames.java
jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeListener.java
jmeter/trunk/xdocs/changes.xml

[asfimport]

@pmouawad (migrated from Bugzilla):
Date: Wed May 29 19:53:36 2013
New Revision: 1487615

URL: http://svn.apache.org/r1487615
Log:
#3131 - Test Action regression, duration value are not record
#3131

Modified:
jmeter/trunk/src/components/org/apache/jmeter/sampler/gui/TestActionGui.java
jmeter/trunk/xdocs/changes.xml

[asfimport]

@pmouawad (migrated from Bugzilla):
Thanks for reporting and investigating.
I cleaned up code of TestActionGui regarding usage of FocusListener which is not necessary.

[asfimport]

Sebb (migrated from Bugzilla):
I agree that the fix to TestActionGui was sensible; it would have been a sensible fix even without the bug as the extra field was unnecessary.

However why does the focus listener now get called after modifyTestElement?

That might affect other GUI elements.
And it might affect future GUI coding where a focus listener might be required.

[asfimport]

@pmouawad (migrated from Bugzilla):
Closing after opening 55103 as from Users point of view this bug is fixed.