Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"audio/x-mpegurl" mime type is erroneously considered as binary by ViewResultsTree #3581

Closed
asfimport opened this issue Apr 12, 2015 · 3 comments

Comments

@asfimport
Copy link
Collaborator

UbikLoadPack support (Bug 57806):
SampleResult#isBinaryType considers that a "audio/x-mpegurl" mime type is binary while it is text.

This is due to:
for (int i = 0; i < BINARY_TYPES.length; i++){
if (ct.startsWith(BINARY_TYPES[i])){
return true;
}
}

This leads to response data being shown as blank in View Results Tree when Text renderer is used

Severity: minor
OS: All

@asfimport
Copy link
Collaborator Author

UbikLoadPack support (migrated from Bugzilla):
Created attachment BUG_57806.patch: Patch fixing issue

BUG_57806.patch
Index: src/core/org/apache/jmeter/samplers/SampleResult.java
===================================================================
--- src/core/org/apache/jmeter/samplers/SampleResult.java	(revision 1671850)
+++ src/core/org/apache/jmeter/samplers/SampleResult.java	(working copy)
@@ -809,7 +809,8 @@
 
     // List of types that are known to be ascii, although they may appear to be binary
     private static final String[] NON_BINARY_TYPES = {
-        "video/f4m",       //$NON-NLS-1$ (Flash Media Manifest)
+        "audio/x-mpegurl",  //$NON-NLS-1$ (HLS Media Manifest)
+        "video/f4m"         //$NON-NLS-1$ (Flash Media Manifest)
         };
 
     /*

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Date: Thu Apr 16 20:20:55 2015
New Revision: 1674146

URL: http://svn.apache.org/r1674146
Log:
#3581 - "audio/x-mpegurl" mime type is erroneously considered as binary by ViewResultsTree
#3581

Modified:
jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleResult.java
jmeter/trunk/xdocs/changes.xml

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Thanks for patch.
Commited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant