Improve JUnit Test code #3789

asfimport · 2016-01-20T14:29:42Z

benoit.wiart (Bug 58897):

It's not possible to use modern JUnit contruct (junit 4+) @test, @RunWith, etc
The test code hide some errors

For example TestSamplingStatCalculator is not executed with ant as it's a junit4 test (it works fine in your IDE)
Some code added a few years ago silently disabled a lot of tests :
when run in headless mode (apache build bot ?) a HeadlessException is thrown but wrapped in an ExceptionInInitializerError
this error stop the JmeterTest suite and the following tests are disabled

suiteSerializableElements
suiteTestElements
suiteBeanComponents
new JMeterTest("createFunctionSet"));
suiteFunctions
new JMeterTest("checkGuiSet"));
new JMeterTest("checkFunctionSet"));
new JMeterTest("resetLocale")

Looks like the test code was frozen when an asteroid hit earth and killed all the dinosaurs.

OS: All

Depends on:

RSyntaxTextArea not compatible with headless testing #3896

asfimport · 2016-01-20T14:32:00Z

benoit.wiart (migrated from Bugzilla):
PR #84
you should not merge this PR as this
it will enable tests that will probably failed
Those tests need to be reviewed by a jmeter ninja or an archaeologist

asfimport · 2016-01-21T08:19:53Z

benoit.wiart (migrated from Bugzilla):
I have a patch for the junit 4 support + exception management.
I need to split it into several PRs to make it reviewable.

Can a committer merge https://github.com/apache/jmeter/pull/81/files before I start providing the PRs ?

asfimport · 2016-01-21T21:03:35Z

benoit.wiart (migrated from Bugzilla):
Step 1

Move jorphan class finder to a more flexible solution when searching for
classes (visitor / filter pattern)
Use it as preparatory step in Jorphan AllTests
Explicitly exclude JMeterTest and TestMenuFactory in headless mode
remove commented code & outdated comments

No change in the number of executed tests *

in headless mode TestMenuFactory is now excluded, it was previously running as a side effect of the strange exception management, but it need a graphics environment.

Jorphan AllTests is a stinky monkey.

PR #85

asfimport · 2016-01-28T22:23:44Z

@pmouawad (migrated from Bugzilla):
Date: Thu Jan 28 22:23:23 2016
New Revision: 1727442

URL: http://svn.apache.org/viewvc?rev=1727442&view=rev
Log:
#3789 : Improve JUnit Test code
#resolve #85
#3789

Added:
jmeter/trunk/src/jorphan/org/apache/jorphan/reflect/ClassFilter.java (with props)
Modified:
jmeter/trunk/src/jorphan/org/apache/jorphan/reflect/ClassFinder.java
jmeter/trunk/test/src/org/apache/jmeter/gui/util/TestMenuFactory.java
jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTest.java
jmeter/trunk/test/src/org/apache/jorphan/test/AllTests.java
jmeter/trunk/xdocs/changes.xml

asfimport · 2016-01-28T23:32:46Z

benoit.wiart (migrated from Bugzilla):
Step 2

Update the junit tests execution to a recent junit runner
No change in the number of executed tests
The console output change but not the process return code

Not that while it's a recent runner you can not use pure junit annotation tests as they're not detected in the classpath.
It will be done in a subsequent patch

This has only been tested locally, it should work on the bot.

PR #94

asfimport · 2016-01-30T12:27:04Z

benoit.wiart (migrated from Bugzilla):
Step 3 : execute JUnit 4 tests

We now scan for classes that extends TestCase (junit3) and for classes that have at least one method annotated with @test
2 new tests executed in TestSamplingStatCalculator

PR #95

asfimport · 2016-02-01T20:22:30Z

@pmouawad (migrated from Bugzilla):
Date: Mon Feb 1 20:21:30 2016
New Revision: 1727996

URL: http://svn.apache.org/viewvc?rev=1727996&view=rev
Log:
#3789 : Improve JUnit Test code
Part 3
#resolve #95
#3789

Modified:
jmeter/trunk/test/src/org/apache/jorphan/test/AllTests.java

asfimport · 2016-02-01T21:46:29Z

benoit.wiart (migrated from Bugzilla):
Step 4 : convert existing tests

this patch is "mechanical"
No change in the number of executed tests
the "suite" style tests kept a junit 3 hierarchy

PR #100

asfimport · 2016-02-02T21:27:18Z

@pmouawad (migrated from Bugzilla):
Date: Tue Feb 2 21:26:49 2016
New Revision: 1728218

URL: http://svn.apache.org/viewvc?rev=1728218&view=rev
Log:
#3789 - Improve JUnit Test code STEP 4
Part 1 patch by B. Wiart
#3789

Modified:
jmeter/trunk/test/src/org/apache/jmeter/timers/PackageTest.java
jmeter/trunk/test/src/org/apache/jmeter/util/PackageTest.java
jmeter/trunk/test/src/org/apache/jmeter/util/TestJMeterUtils.java
jmeter/trunk/test/src/org/apache/jmeter/visualizers/TestRenderAsJson.java
jmeter/trunk/test/src/org/apache/jorphan/TestFunctorUsers.java
jmeter/trunk/test/src/org/apache/jorphan/TestXMLBuffer.java
jmeter/trunk/test/src/org/apache/jorphan/collections/PackageTest.java
jmeter/trunk/test/src/org/apache/jorphan/exec/TestKeyToolUtils.java
jmeter/trunk/test/src/org/apache/jorphan/math/TestStatCalculator.java
jmeter/trunk/test/src/org/apache/jorphan/reflect/TestClassTools.java
jmeter/trunk/test/src/org/apache/jorphan/reflect/TestFunctor.java
jmeter/trunk/test/src/org/apache/jorphan/util/TestConverter.java
jmeter/trunk/test/src/org/apache/jorphan/util/TestJorphanUtils.java

asfimport · 2016-02-02T21:31:50Z

@pmouawad (migrated from Bugzilla):
Date: Tue Feb 2 21:30:46 2016
New Revision: 1728219

URL: http://svn.apache.org/viewvc?rev=1728219&view=rev
Log:
#3789 - Improve JUnit Test code STEP 4
Part 2 patch by B. Wiart
#3789

Modified:
jmeter/trunk/test/src/org/apache/jmeter/report/core/SampleMetadataTest.java
jmeter/trunk/test/src/org/apache/jmeter/report/core/TestCsvSampleWriter.java
jmeter/trunk/test/src/org/apache/jmeter/report/processor/FieldSampleComparatorTest.java
jmeter/trunk/test/src/org/apache/jmeter/samplers/TestSampleResult.java
jmeter/trunk/test/src/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java
jmeter/trunk/test/src/org/apache/jmeter/save/TestCSVSaveService.java
jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
jmeter/trunk/test/src/org/apache/jmeter/services/TestFileServer.java
jmeter/trunk/test/src/org/apache/jmeter/testbeans/gui/PackageTest.java
jmeter/trunk/test/src/org/apache/jmeter/testbeans/gui/TestBooleanPropertyEditor.java
jmeter/trunk/test/src/org/apache/jmeter/testbeans/gui/TestComboStringEditor.java
jmeter/trunk/test/src/org/apache/jmeter/testbeans/gui/TestFieldStringEditor.java
jmeter/trunk/test/src/org/apache/jmeter/testelement/PackageTest.java
jmeter/trunk/test/src/org/apache/jmeter/testelement/property/PackageTest.java
jmeter/trunk/test/src/org/apache/jmeter/threads/TestJMeterContextService.java
jmeter/trunk/test/src/org/apache/jmeter/threads/TestTestCompiler.java

asfimport · 2016-02-02T21:38:58Z

@pmouawad (migrated from Bugzilla):
Date: Tue Feb 2 21:35:58 2016
New Revision: 1728220

URL: http://svn.apache.org/viewvc?rev=1728220&view=rev
Log:
#3789 - Improve JUnit Test code STEP 4
Part 3 patch by B. Wiart
#3789

Modified:
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/proxy/TestHttpRequestHdr.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/proxy/TestProxyControl.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/sampler/PostWriterTest.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/sampler/PutWriterTest.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/sampler/TestHTTPSamplers.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/sampler/TestHTTPSamplersAgainstHttpMirrorServer.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/util/TestHTTPArgument.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/util/TestHTTPFileArg.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/util/TestHTTPFileArgs.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/util/TestHTTPUtils.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/util/accesslog/TestLogFilter.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/util/accesslog/TestTCLogParser.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/ldap/config/gui/PackageTest.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/tcp/sampler/BinaryTCPClientImplTest.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/tcp/sampler/LengthPrefixedBinaryTCPClientImplTest.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/tcp/sampler/TCPClientDecoratorTest.java

asfimport · 2016-02-02T21:43:26Z

@pmouawad (migrated from Bugzilla):
Date: Tue Feb 2 21:39:15 2016
New Revision: 1728221

URL: http://svn.apache.org/viewvc?rev=1728221&view=rev
Log:
#3789 - Improve JUnit Test code STEP 4
Part 4 patch by B. Wiart
#3789

Modified:
jmeter/trunk/test/src/org/apache/jmeter/monitor/model/TestObjectFactory.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/config/MultipartUrlConfigTest.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/config/UrlConfigTest.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestAuthManager.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCacheManager.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCacheManagerHC4.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestDNSCacheManager.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/gui/TestHttpTestSampleGui.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/modifier/TestAnchorModifier.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/modifier/TestURLRewritingModifier.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/TestHTMLParser.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/TestHtmlParsingUtils.java

asfimport · 2016-02-02T21:47:08Z

@pmouawad (migrated from Bugzilla):
Date: Tue Feb 2 21:45:57 2016
New Revision: 1728223

URL: http://svn.apache.org/viewvc?rev=1728223&view=rev
Log:
#3789 - Improve JUnit Test code
#resolve #100
#3789

Added:
jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTestCaseJUnit3.java (with props)
Modified:
jmeter/trunk/test/src/org/apache/commons/cli/avalon/ClutilTestCase.java
jmeter/trunk/test/src/org/apache/jmeter/JMeterVersionTest.java
jmeter/trunk/test/src/org/apache/jmeter/assertions/MD5HexAssertionTest.java
jmeter/trunk/test/src/org/apache/jmeter/assertions/ResponseAssertionTest.java
jmeter/trunk/test/src/org/apache/jmeter/assertions/SMIMEAssertionTest.java
jmeter/trunk/test/src/org/apache/jmeter/assertions/SizeAssertionTest.java
jmeter/trunk/test/src/org/apache/jmeter/assertions/XMLSchemaAssertionTest.java
jmeter/trunk/test/src/org/apache/jmeter/assertions/XPathAssertionTest.java
jmeter/trunk/test/src/org/apache/jmeter/config/TestCVSDataSet.java
jmeter/trunk/test/src/org/apache/jmeter/config/gui/TestArgumentsPanel.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestGenericController.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestIfController.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestInterleaveControl.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestLoopController.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestOnceOnlyController.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestRandomOrderController.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestRunTime.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestSwitchController.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestThroughputController.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestWhileController.java
jmeter/trunk/test/src/org/apache/jmeter/engine/DistributedRunnerTest.java
jmeter/trunk/test/src/org/apache/jmeter/engine/TestTreeCloner.java
jmeter/trunk/test/src/org/apache/jmeter/engine/util/PackageTest.java
jmeter/trunk/test/src/org/apache/jmeter/engine/util/TestValueReplacer.java
jmeter/trunk/test/src/org/apache/jmeter/extractor/TestRegexExtractor.java
jmeter/trunk/test/src/org/apache/jmeter/extractor/TestXPathExtractor.java
jmeter/trunk/test/src/org/apache/jmeter/functions/PackageTest.java
jmeter/trunk/test/src/org/apache/jmeter/functions/TestFileRowColContainer.java
jmeter/trunk/test/src/org/apache/jmeter/functions/TestJexl2Function.java
jmeter/trunk/test/src/org/apache/jmeter/functions/TestJexl3Function.java
jmeter/trunk/test/src/org/apache/jmeter/functions/TestJexlFunction.java
jmeter/trunk/test/src/org/apache/jmeter/functions/TestRegexFunction.java
jmeter/trunk/test/src/org/apache/jmeter/functions/TestTimeFunction.java
jmeter/trunk/test/src/org/apache/jmeter/gui/action/TestLoad.java
jmeter/trunk/test/src/org/apache/jmeter/gui/action/TestSave.java
jmeter/trunk/test/src/org/apache/jmeter/gui/util/JSyntaxTextAreaTest.java
jmeter/trunk/test/src/org/apache/jmeter/gui/util/TestMenuFactory.java
jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTest.java
jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTestCase.java
jmeter/trunk/xdocs/changes.xml

asfimport · 2016-02-03T15:25:11Z

benoit.wiart (migrated from Bugzilla):
Step 5

misc clean up
remove empty test
remove commented code
split some tests
explicitly disable org.apache.jmeter.protocol.http.sampler.PackageTest when in headless mode

PR #104

asfimport · 2016-02-03T15:27:01Z

benoit.wiart (migrated from Bugzilla):
reopen as i have 1 more step (see comment 14)

asfimport · 2016-02-03T15:27:58Z

benoit.wiart (migrated from Bugzilla):
After step 5 this bug could be closed.

asfimport · 2016-02-04T08:21:04Z

@pmouawad (migrated from Bugzilla):
Date: Thu Feb 4 08:14:13 2016
New Revision: 1728418

URL: http://svn.apache.org/viewvc?rev=1728418&view=rev
Log:
#3789 - Improve JUnit Test code STEP 5
patch by B. Wiart
#resolve #104
#3789

Added:
jmeter/trunk/test/src/org/apache/jmeter/functions/EvalFunctionTest.java (with props)
jmeter/trunk/test/src/org/apache/jmeter/functions/FunctionTestHelper.java (with props)
jmeter/trunk/test/src/org/apache/jmeter/functions/RandomFunctionTest.java (with props)
jmeter/trunk/test/src/org/apache/jmeter/functions/StringFromFileFunctionTest.java (with props)
jmeter/trunk/test/src/org/apache/jmeter/functions/SumFunctionTest.java (with props)
jmeter/trunk/test/src/org/apache/jmeter/functions/VariableTest.java (with props)
Removed:
jmeter/trunk/test/src/org/apache/jmeter/gui/action/PackageTest.java
Modified:
jmeter/trunk/src/functions/org/apache/jmeter/functions/EvalFunction.java
jmeter/trunk/src/functions/org/apache/jmeter/functions/EvalVarFunction.java
jmeter/trunk/test/src/org/apache/jmeter/assertions/SizeAssertionTest.java
jmeter/trunk/test/src/org/apache/jmeter/assertions/XMLSchemaAssertionTest.java
jmeter/trunk/test/src/org/apache/jmeter/assertions/XPathAssertionTest.java
jmeter/trunk/test/src/org/apache/jmeter/engine/util/TestValueReplacer.java
jmeter/trunk/test/src/org/apache/jmeter/functions/PackageTest.java
jmeter/trunk/test/src/org/apache/jmeter/gui/action/TestLoad.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/modifier/TestURLRewritingModifier.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/TestHTMLParser.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/sampler/PackageTest.java
jmeter/trunk/test/src/org/apache/jmeter/testbeans/gui/PackageTest.java
jmeter/trunk/test/src/org/apache/jmeter/testbeans/gui/TestBooleanPropertyEditor.java
jmeter/trunk/test/src/org/apache/jmeter/testbeans/gui/TestComboStringEditor.java

asfimport · 2016-02-04T13:05:19Z

benoit.wiart (migrated from Bugzilla):
what's left :

use junit categories to disable non headless tests (use junit categories to exclude tests that need a gui #3819)
split the *.PackageTest into individual tests
remove / convert the last junit 3 tests

asfimport · 2016-03-09T11:10:18Z

Sebb (migrated from Bugzilla):
The commit
http://svn.apache.org/viewvc?rev=1727442&view=rev
disabled org.apache.jmeter.junit.JMeterTest completely for non-GUI environments

This is wrong, as a lot of the tests in that class do not require a GUI.

asfimport · 2016-03-10T18:49:22Z

Sebb (migrated from Bugzilla):
It looks like the problem was caused by RSyntaxTextArea.

It's not possible to instantiate it if the code is running Headless.
This is not the case for JTextArea, which can at least be instantiated, even if it cannot be used.

I think this needs to be resolved somehow, because there are some useful tests that cannot be run under Jenkins etc. For example, checking that the GUI components have entries in component_reference.

Ideally RSyntaxtTextArea should behave like JTextArea and allow non-Headless instantiation, but that may take a while to get fixed.

Other approaches:

change the GUI classes that use the class to delay instantiation until actually needed. This may be tricky to do.
change the JMeter class JSyntaxTextArea to use static getInstance methods instead of ctors; these can handle the Headless issue. This may also be tricky.

asfimport · 2016-03-11T13:35:36Z

Sebb (migrated from Bugzilla):
(In reply to Sebb from comment 20)

It looks like the problem was caused by RSyntaxTextArea.

See #3896 regarding RSyntaxTextArea

asfimport · 2016-03-11T13:44:00Z

Sebb (migrated from Bugzilla):
URL: http://svn.apache.org/viewvc?rev=1734556&view=rev
Log:
Improve JUnit Test code
Re-enable headless testing
#3789

Modified:
jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTest.java

asfimport · 2016-03-11T17:39:07Z

@pmouawad (migrated from Bugzilla):
(In reply to Sebb from comment 19)

The commit
http://svn.apache.org/viewvc?rev=1727442&view=rev
disabled org.apache.jmeter.junit.JMeterTest completely for non-GUI
environments

This is wrong, as a lot of the tests in that class do not require a GUI.

(In reply to benoit.wiart from comment 18)

what's left :

use junit categories to disable non headless tests (use junit categories to exclude tests that need a gui #3819)

split the *.PackageTest into individual tests

remove / convert the last junit 3 tests

I don't think it's the commit that did this.
All changes done in this task (a lot) enabled much cleaned management of Headless case.
Nothing was disabled accidentaly.
As you can see through #3896, the issue with JSyntaxTextarea was always here.

Regards

asfimport · 2016-05-07T11:59:23Z

Sebb (migrated from Bugzilla):
(In reply to Philippe Mouawad from comment 13)

Date: Tue Feb 2 21:45:57 2016
New Revision: 1728223

URL: http://svn.apache.org/viewvc?rev=1728223&view=rev
Log:
#3789 - Improve JUnit Test code
#resolve #100
#3789

Added:
jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTestCaseJUnit3.java
(with props)
Modified:
jmeter/trunk/test/src/org/apache/commons/cli/avalon/ClutilTestCase.java
jmeter/trunk/test/src/org/apache/jmeter/JMeterVersionTest.java

jmeter/trunk/test/src/org/apache/jmeter/assertions/MD5HexAssertionTest.java

jmeter/trunk/test/src/org/apache/jmeter/assertions/ResponseAssertionTest.java

jmeter/trunk/test/src/org/apache/jmeter/assertions/SMIMEAssertionTest.java
jmeter/trunk/test/src/org/apache/jmeter/assertions/SizeAssertionTest.java

jmeter/trunk/test/src/org/apache/jmeter/assertions/XMLSchemaAssertionTest.
java

jmeter/trunk/test/src/org/apache/jmeter/assertions/XPathAssertionTest.java
jmeter/trunk/test/src/org/apache/jmeter/config/TestCVSDataSet.java

jmeter/trunk/test/src/org/apache/jmeter/config/gui/TestArgumentsPanel.java

jmeter/trunk/test/src/org/apache/jmeter/control/TestGenericController.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestIfController.java

jmeter/trunk/test/src/org/apache/jmeter/control/TestInterleaveControl.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestLoopController.java

jmeter/trunk/test/src/org/apache/jmeter/control/TestOnceOnlyController.java

jmeter/trunk/test/src/org/apache/jmeter/control/TestRandomOrderController.
java
jmeter/trunk/test/src/org/apache/jmeter/control/TestRunTime.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestSwitchController.java

jmeter/trunk/test/src/org/apache/jmeter/control/TestThroughputController.java
jmeter/trunk/test/src/org/apache/jmeter/control/TestWhileController.java
jmeter/trunk/test/src/org/apache/jmeter/engine/DistributedRunnerTest.java
jmeter/trunk/test/src/org/apache/jmeter/engine/TestTreeCloner.java
jmeter/trunk/test/src/org/apache/jmeter/engine/util/PackageTest.java

jmeter/trunk/test/src/org/apache/jmeter/engine/util/TestValueReplacer.java
jmeter/trunk/test/src/org/apache/jmeter/extractor/TestRegexExtractor.java
jmeter/trunk/test/src/org/apache/jmeter/extractor/TestXPathExtractor.java
jmeter/trunk/test/src/org/apache/jmeter/functions/PackageTest.java

jmeter/trunk/test/src/org/apache/jmeter/functions/TestFileRowColContainer.
java
jmeter/trunk/test/src/org/apache/jmeter/functions/TestJexl2Function.java
jmeter/trunk/test/src/org/apache/jmeter/functions/TestJexl3Function.java
jmeter/trunk/test/src/org/apache/jmeter/functions/TestJexlFunction.java
jmeter/trunk/test/src/org/apache/jmeter/functions/TestRegexFunction.java
jmeter/trunk/test/src/org/apache/jmeter/functions/TestTimeFunction.java
jmeter/trunk/test/src/org/apache/jmeter/gui/action/TestLoad.java
jmeter/trunk/test/src/org/apache/jmeter/gui/action/TestSave.java
jmeter/trunk/test/src/org/apache/jmeter/gui/util/JSyntaxTextAreaTest.java
jmeter/trunk/test/src/org/apache/jmeter/gui/util/TestMenuFactory.java
jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTest.java
jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTestCase.java
jmeter/trunk/xdocs/changes.xml

This has has broken Test classes that depend on JMeterTestCase.

They cannot now be run stand-alone because JMeterTestCase no longer extends TestCase.

asfimport · 2016-05-07T12:52:42Z

Sebb (migrated from Bugzilla):
(In reply to Sebb from comment 24)

(In reply to Philippe Mouawad from comment 13)
> Date: Tue Feb 2 21:45:57 2016
> New Revision: 1728223
>
> URL: http://svn.apache.org/viewvc?rev=1728223&view=rev
> Log:
> #3789 - Improve JUnit Test code
> #resolve #100
> #3789
>
> Added:
> jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTestCaseJUnit3.java
> (with props)
> Modified:
> jmeter/trunk/test/src/org/apache/commons/cli/avalon/ClutilTestCase.java
> jmeter/trunk/test/src/org/apache/jmeter/JMeterVersionTest.java
>
> jmeter/trunk/test/src/org/apache/jmeter/assertions/MD5HexAssertionTest.java
>
> jmeter/trunk/test/src/org/apache/jmeter/assertions/ResponseAssertionTest.java
>
> jmeter/trunk/test/src/org/apache/jmeter/assertions/SMIMEAssertionTest.java
> jmeter/trunk/test/src/org/apache/jmeter/assertions/SizeAssertionTest.java
>
> jmeter/trunk/test/src/org/apache/jmeter/assertions/XMLSchemaAssertionTest.
> java
>
> jmeter/trunk/test/src/org/apache/jmeter/assertions/XPathAssertionTest.java
> jmeter/trunk/test/src/org/apache/jmeter/config/TestCVSDataSet.java
>
> jmeter/trunk/test/src/org/apache/jmeter/config/gui/TestArgumentsPanel.java
>
> jmeter/trunk/test/src/org/apache/jmeter/control/TestGenericController.java
> jmeter/trunk/test/src/org/apache/jmeter/control/TestIfController.java
>
> jmeter/trunk/test/src/org/apache/jmeter/control/TestInterleaveControl.java
> jmeter/trunk/test/src/org/apache/jmeter/control/TestLoopController.java
>
> jmeter/trunk/test/src/org/apache/jmeter/control/TestOnceOnlyController.java
>
> jmeter/trunk/test/src/org/apache/jmeter/control/TestRandomOrderController.
> java
> jmeter/trunk/test/src/org/apache/jmeter/control/TestRunTime.java
> jmeter/trunk/test/src/org/apache/jmeter/control/TestSwitchController.java
>
> jmeter/trunk/test/src/org/apache/jmeter/control/TestThroughputController.java
> jmeter/trunk/test/src/org/apache/jmeter/control/TestWhileController.java
> jmeter/trunk/test/src/org/apache/jmeter/engine/DistributedRunnerTest.java
> jmeter/trunk/test/src/org/apache/jmeter/engine/TestTreeCloner.java
> jmeter/trunk/test/src/org/apache/jmeter/engine/util/PackageTest.java
>
> jmeter/trunk/test/src/org/apache/jmeter/engine/util/TestValueReplacer.java
> jmeter/trunk/test/src/org/apache/jmeter/extractor/TestRegexExtractor.java
> jmeter/trunk/test/src/org/apache/jmeter/extractor/TestXPathExtractor.java
> jmeter/trunk/test/src/org/apache/jmeter/functions/PackageTest.java
>
> jmeter/trunk/test/src/org/apache/jmeter/functions/TestFileRowColContainer.
> java
> jmeter/trunk/test/src/org/apache/jmeter/functions/TestJexl2Function.java
> jmeter/trunk/test/src/org/apache/jmeter/functions/TestJexl3Function.java
> jmeter/trunk/test/src/org/apache/jmeter/functions/TestJexlFunction.java
> jmeter/trunk/test/src/org/apache/jmeter/functions/TestRegexFunction.java
> jmeter/trunk/test/src/org/apache/jmeter/functions/TestTimeFunction.java
> jmeter/trunk/test/src/org/apache/jmeter/gui/action/TestLoad.java
> jmeter/trunk/test/src/org/apache/jmeter/gui/action/TestSave.java
> jmeter/trunk/test/src/org/apache/jmeter/gui/util/JSyntaxTextAreaTest.java
> jmeter/trunk/test/src/org/apache/jmeter/gui/util/TestMenuFactory.java
> jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTest.java
> jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTestCase.java
> jmeter/trunk/xdocs/changes.xml

This has has broken Test classes that depend on JMeterTestCase.

They cannot now be run stand-alone because JMeterTestCase no longer extends
TestCase.

Ignore that. The problem is that JMeterTestCase used to support JUnit3; it now only supports JUnit4.

asfimport closed this as completed May 7, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve JUnit Test code #3789

Improve JUnit Test code #3789

asfimport commented Jan 20, 2016

asfimport commented Jan 20, 2016

asfimport commented Jan 21, 2016

asfimport commented Jan 21, 2016

asfimport commented Jan 28, 2016

asfimport commented Jan 28, 2016

asfimport commented Jan 30, 2016

asfimport commented Feb 1, 2016

asfimport commented Feb 1, 2016

asfimport commented Feb 2, 2016

asfimport commented Feb 2, 2016

asfimport commented Feb 2, 2016

asfimport commented Feb 2, 2016

asfimport commented Feb 2, 2016

asfimport commented Feb 3, 2016

asfimport commented Feb 3, 2016

asfimport commented Feb 3, 2016

asfimport commented Feb 4, 2016

asfimport commented Feb 4, 2016

asfimport commented Mar 9, 2016

asfimport commented Mar 10, 2016

asfimport commented Mar 11, 2016

asfimport commented Mar 11, 2016

asfimport commented Mar 11, 2016

asfimport commented May 7, 2016

asfimport commented May 7, 2016

Improve JUnit Test code #3789

Improve JUnit Test code #3789

Comments

asfimport commented Jan 20, 2016

asfimport commented Jan 20, 2016

asfimport commented Jan 21, 2016

asfimport commented Jan 21, 2016

asfimport commented Jan 28, 2016

asfimport commented Jan 28, 2016

asfimport commented Jan 30, 2016

asfimport commented Feb 1, 2016

asfimport commented Feb 1, 2016

asfimport commented Feb 2, 2016

asfimport commented Feb 2, 2016

asfimport commented Feb 2, 2016

asfimport commented Feb 2, 2016

asfimport commented Feb 2, 2016

asfimport commented Feb 3, 2016

asfimport commented Feb 3, 2016

asfimport commented Feb 3, 2016

asfimport commented Feb 4, 2016

asfimport commented Feb 4, 2016

asfimport commented Mar 9, 2016

asfimport commented Mar 10, 2016

asfimport commented Mar 11, 2016

asfimport commented Mar 11, 2016

asfimport commented Mar 11, 2016

asfimport commented May 7, 2016

asfimport commented May 7, 2016