JLabeledChoice isn't localized (L10N)

[asfimport]

@milamberspace (Bug 59131):
The new change of the Method field to have an editable field to add or delete a method bring an issue in the localized versions of JMeter, the label of Add and Delete button isn't localize, it's hard-coded in the src/jorphan/org/apache/jorphan/gui/JLabeledChoice.java L149/L153.

This class is build inside the jorphan.jar package, which don't have any import form JMeter API, so it's not possible to use the JMeter L10N mechanism.

Three options:

1/ Change the "Add" and "Del" label with " + " and " - " characters. Not necessary to add some L10N mechanism, the plus and minus are recognized for Add and Delete action in UI.

2/ Use icons for + and - (same than the collapse/expand toolbar button). Need to add inside the jorphan.jar the icons and manage the HiDPI (some properties to add or try to manage this automatically)

3/ Add some L10N messages.properties mechanism inside the jorphan.jar and use this to translate the UI.

In attachment, some draft screenshot.

What is your prefer option ? 1 / 2 / 3 / other way ?

Created attachment JLabeledChoice_Not_L10N.png: JLabeledChoice Not L10N

Version: Nightly
OS: All

Depends on:

• HTTP Request : Make Method field editable so that additional methods (Webdav) can be added easily #3863

[asfimport]

@milamberspace (migrated from Bugzilla):
Created attachment JLabeledChoice_with_plus_minus_as_char.png: Plus or Minus are characters

[asfimport]

@milamberspace (migrated from Bugzilla):
Created attachment JLabeledChoice_with_plus_minus_as_icons.png: Plus or Minus are icons

[asfimport]

@pmouawad (migrated from Bugzilla):
(In reply to Milamber from comment 0)

Created attachment 33630 [details]
JLabeledChoice Not L10N

The new change of the Method field to have an editable field to add or
delete a method bring an issue in the localized versions of JMeter, the
label of Add and Delete button isn't localize, it's hard-coded in the
src/jorphan/org/apache/jorphan/gui/JLabeledChoice.java L149/L153.

This class is build inside the jorphan.jar package, which don't have any
import form JMeter API, so it's not possible to use the JMeter L10N
mechanism.

Three options:

1/ Change the "Add" and "Del" label with " + " and " - " characters. Not
necessary to add some L10N mechanism, the plus and minus are recognized for
Add and Delete action in UI.

+1 for me

2/ Use icons for + and - (same than the collapse/expand toolbar button).
Need to add inside the jorphan.jar the icons and manage the HiDPI (some
properties to add or try to manage this automatically)

3/ Add some L10N messages.properties mechanism inside the jorphan.jar and
use this to translate the UI.

In attachment, some draft screenshot.

What is your prefer option ? 1 / 2 / 3 / other way ?

[asfimport]

Sebb (migrated from Bugzilla):
I'm not sure why there needs to be a Delete function. Surely one just does not select it?

Indeed, I'm not sure why there needs to be an Add button either.

The way this works for the TestBean-based GUIs is to have an editable entry in the drop-down box. For example like the Language field in the JSR223Sampler.

This can then either be a fixed value or even a variable reference.

If this were done there would be no L10N issue.

So my vote is for 'other way'.

[asfimport]

Sebb (migrated from Bugzilla):
Solved for HTTPRequest by dropping the Buttons

URL: http://svn.apache.org/viewvc?rev=1734185&view=rev
Log:
HTTP Request : Make Method field editable so that additional methods (Webdav) can be added easily
Don't display Add/Del buttons
#3863

Modified:
jmeter/trunk/src/jorphan/org/apache/jorphan/gui/JLabeledChoice.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/config/gui/UrlConfigGui.java

[asfimport]

Sebb (migrated from Bugzilla):
Renamed; it's not HTTP specific

[asfimport]

Sebb (migrated from Bugzilla):
(In reply to Sebb from comment 4)

I'm not sure why there needs to be a Delete function. Surely one just does
not select it?

Indeed, I'm not sure why there needs to be an Add button either.

The way this works for the TestBean-based GUIs is to have an editable entry
in the drop-down box. For example like the Language field in the
JSR223Sampler.

This can then either be a fixed value or even a variable reference.

If this were done there would be no L10N issue.

So my vote is for 'other way'.

I was confused by the title; it's a generic L10N issue, not just for HTTP GUI, so it still may need addressing at some point.

Another solution would be to move the class out of Jorphan so the property mechanisms are available.

I think we need to see if there are other classes that have the same issue.