TCPSampler : Latency is not measured for TCP Sampler

[asfimport]

Tamas Szabadi (Bug 60156):
TCP Sampler results have always 0 as latency. It seems that .latencyEnd() is not called anywhere in the TCPSampler or in its implementations.

I can't just create a new custom TCPSamplerImpl implementation because the TCPClient interface doesn't specify a read method with the SampleResult passed in to make it able to call 'latencyEnd' on it.

Votes in Bugzilla: 2
OS: All

[asfimport]

@pmouawad (migrated from Bugzilla):
@Team, another Bugzilla where Java8 default method would allow us to add to TCPClient:

public String read(InputStream is, SampleResult sampleResult)
        throws ReadException 

Regards

[asfimport]

UbikLoadPack support (migrated from Bugzilla):
Hello,
Proposed PR for this:

• Fix to BUG_60156 #306

Please review.

Thanks

[asfimport]

@pmouawad (migrated from Bugzilla):
Author: pmouawad
Date: Fri Sep 8 11:55:40 2017
New Revision: 1807719

URL: http://svn.apache.org/viewvc?rev=1807719&view=rev
Log:
#4121 - TCPSampler : Latency is not measured for TCP Sampler
Contributed by UbikLoadPack
#4121

Modified:
jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/AbstractTCPClient.java
jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/BinaryTCPClientImpl.java
jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/LengthPrefixedBinaryTCPClientImpl.java
jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPClient.java
jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPClientImpl.java
jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java
jmeter/trunk/xdocs/changes.xml

[asfimport]

@pmouawad (migrated from Bugzilla):
Author: pmouawad
Date: Fri Sep 8 17:03:16 2017
New Revision: 1807786

URL: http://svn.apache.org/viewvc?rev=1807786&view=rev
Log:
#4121 - TCPSampler : Latency is not measured for TCP Sampler
Contributed by UbikLoadPack
Oups forgot to commit tests
#4121

Modified:
jmeter/trunk/test/src/org/apache/jmeter/protocol/tcp/sampler/BinaryTCPClientImplTest.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/tcp/sampler/LengthPrefixedBinaryTCPClientImplTest.java