Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MD5Hex Assertion to Digest Assertion #4573

Open
asfimport opened this issue Nov 8, 2017 · 2 comments
Open

Upgrade MD5Hex Assertion to Digest Assertion #4573

asfimport opened this issue Nov 8, 2017 · 2 comments

Comments

@asfimport
Copy link
Collaborator

orimarko (Bug 61737):
I suggest upgrading MD5Hex Assertion to Digest Assertion

Currently it only assert using MD5 algorithm, but we can allow other SHA assertions.
Support similar algorithms as the new __digest function.

OS: All

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Hello,
Looks like a good idea.
Just to keep backward compatibility , can you proceed the following way if you intend to submit a patch:

  • Keep class name as it but update javadocs and docs
  • A select box should provide available algorithm, defaulting to MD5 for backward compatibility
  • I supppose there will be other parameters depending on algorithm
  • MD5Hex should become HashHex

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
It would also be interesting to make this assertion appliable on Variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant