ModuleController cloning by Run behaves differently wether in GUI or Non GUI mode

[asfimport]

UbikLoadPack support (Bug 62806):
Hello,
Working with 3rd party plugin we noticed a difference in behaviour between GUI and NON GUI mode.

One particular 3rd party component that implemented NoThreadClone was behaving in a wrong way in NON GUI Mode.
See:

• https://groups.google.com/forum/#!topic/jmeter-plugins/YEU-nstQ4oc

After further analysis it appears issue is in Core JMeter .
When running a test in GUI mode , a clone tree withour honouring NoThreadClone happens:

• https://github.com/apache/jmeter/blob/v5_0/src/core/org/apache/jmeter/gui/action/Start.java#L205

But in GUI mode, so such thing happens.

This triggers an issue when you use at least twice a ModuleController that references a Component that implements NoThreadClone.

In the attached test plan, we have:

• TG-Participant1-Input using a ModuleController-Sender referencing Simple-Controller-Referenced
• TG-Participant2-Input using a ModuleController-Sender referencing Simple-Controller-Referenced

We end up having in NON GUI only 1 instance of NoThreadClone-Element while in GUI mode we have 2.

Created attachment Screen Shot 2018-10-08 at 11.07.13.png: Test plan screenshot

Severity: major
OS: All

[asfimport]

@pmouawad (migrated from Bugzilla):
Author: pmouawad
Date: Mon Oct 8 14:57:46 2018
New Revision: 1843158

URL: http://svn.apache.org/viewvc?rev=1843158&view=rev
Log:
#4889 : ModuleController cloning by Run behaves differently wether in GUI or Non GUI mode
Contributed by UbikLoadPack
#4889

Modified:
jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/RemoteStart.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/Start.java
jmeter/trunk/xdocs/changes.xml

[asfimport]

@pmouawad (migrated from Bugzilla):
Author: pmouawad
Date: Tue Nov 6 13:39:15 2018
New Revision: 1845917

URL: http://svn.apache.org/viewvc?rev=1845917&view=rev
Log:
#4889 ModuleController cloning by Run behaves differently wether in GUI or Non GUI mode.
Reinstate old method signature to avoid NoSuchMethodError in calling plugins and deprecate it
#4889

Modified:
jmeter/trunk/src/core/org/apache/jmeter/JMeter.java