Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying Proxy server scheme for HTTP request sampler, Advanced tab and command line option #4894

Closed
asfimport opened this issue Oct 16, 2018 · 7 comments

Comments

@asfimport
Copy link
Collaborator

Hitesh Patel (Bug 62829):
On HTTP request sampler, advanced tab, proxy server information like IP/hostname and port can be specified, but there is no place to specify the protocol to use. Proxy server could be using https but there is no way to specify to use that protocol for the proxy.

There needs to be a new field added to allow putting in protocol value and make use of it for making the request.

OS: All

Duplicates:

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Can you provide an example of the expected configuration ?
Thank you

@asfimport
Copy link
Collaborator Author

Hitesh Patel (migrated from Bugzilla):
Image of what http request default should look like. http request sampler would be similar.

I have a patch which I will submit soon.

Created attachment JMeter Http request defaults - proxy server protocol.png: Example of what needs to be added

Example of what needs to be added

@asfimport
Copy link
Collaborator Author

Hitesh Patel (migrated from Bugzilla):
Submitted pull request: #413

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Thanks for the PR.

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Author: pmouawad
Date: Sun Nov 18 21:16:17 2018
New Revision: 1846866

URL: http://svn.apache.org/viewvc?rev=1846866&view=rev
Log:
#4894 - Allow specifying Proxy server scheme for HTTP request sampler, Advanced tab and command line option

This closes #413
Contributed by Hitesh Patel
#4894

Modified:
jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/config/gui/HttpDefaultsGui.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/gui/HttpTestSampleGui.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPAbstractImpl.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHCAbstractImpl.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
jmeter/trunk/xdocs/changes.xml
jmeter/trunk/xdocs/usermanual/get-started.xml

@asfimport
Copy link
Collaborator Author

@pmouawad (migrated from Bugzilla):
Thanks for contribution.

Can you please test nightly build once it is available with and without scheme to ensure there is not issue ?

Thank you.

@asfimport
Copy link
Collaborator Author

Hitesh Patel (migrated from Bugzilla):
(In reply to Philippe Mouawad from comment 6)

Thanks for contribution.

Can you please test nightly build once it is available with and without
scheme to ensure there is not issue ?

Thank you.

From https://builds.apache.org/job/JMeter-trunk/6971/, downloaded apache-jmeter-r1846867.zip
Unzipped apache-jmeter-r1846867.zip

Ran one of our work performance tests with apache-jmeter-r1846867/bin/jmeter --proxyHost internal.proxyHost --proxyPort 1234 --proxyScheme https ...
from GUI and command line. Verified test ran successfully as expected.

Ran the same test without any proxy host/port/scheme information, on command line, with running test via GUI and command line. Test run failed as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant