Code Textbox Text Colour

[asfimport]

nathan88wise (Bug 66157):
When you use any theme, the default text colour (black) is there no matter the theme. If you use a dark theme - it becomes a nightmare to read the text. It's also quite hard to read the other coloured text.

The current solution we're using it to downgrade all of the DarkLAF jars to v2.4.8 as suggested by this Stack Overflow post: https://stackoverflow.com/questions/67430501/jmeter-change-font-colour/68407296#68407296

It would be nice if we didn't have to do this.

Created attachment Nasty%20Formatting.png: JSR223 Textbox input with Darcula

Severity: normal
OS: All

[asfimport]

@FSchumacher (migrated from Bugzilla):
Thanks for the report. I opened #719 with a fix.

[asfimport]

@FSchumacher (migrated from Bugzilla):
@nathan, can you check next nightly and report back, if this is fixed?

commit b914b71
AuthorDate: Tue Jul 5 16:16:38 2022 +0200

Correct theme for darklaf on rsyntaxtextarea

The id of the theme has been changed to all lowercase

[Bug 66517](https://bz.apache.org/bugzilla//show_bug.cgi?id=66517&redirect=false)
Closes #719

---

.../src/main/java/org/apache/jmeter/gui/action/LookAndFeelCommand.java | 2 +-
xdocs/changes.xml | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)

[asfimport]

nathan88wise (migrated from Bugzilla):
Just tried the latest one (r236-7548000b1f1dc6708e2186afa721df71057b8082) and it looked the exact same to me - not sure if this one has your fix in it though.

[asfimport]

@FSchumacher (migrated from Bugzilla):
Created attachment Bildschirmfoto%20vom%202022-07-08%2011-53-10.png: How it looks in my machine with current trunk

[asfimport]

@FSchumacher (migrated from Bugzilla):
Maybe the nightly has not catched up with trunk. Could you try the builds from trunk: https://ci-builds.apache.org/job/JMeter/job/JMeter-trunk/lastSuccessfulBuild/artifact/src/dist/build/distributions/ ?

[asfimport]

nathan88wise (migrated from Bugzilla):
Tried the trunk build and messed around with some other elements in a test plan.
Looks good to me!

[asfimport]

Brian Tully (migrated from Bugzilla):
I had posted several related bugs related to Darklaf and dark themes, where textareas were unreadable due to the dark text against a dark background. In my bug reports I was referring to the textareas within View Results Tree that use syntax coloring (e.g., request headers, response headers, etc).

#5257

#5507

I also filed a bug within the Darkflaf project at weisJ/darklaf#328 where Jannis was kind enough to point me to b914b71 which lead me to this bug report.

I am hoping that this really fixes the issue so that I can finally upgrade from JMeter 5.2.1.

I will also try testing the trunk build to make sure it's also working for me on my Mac. I know this bug is listed as resolved/closed, but I'll report back with my results and reopen if needed.

Thanks!
Brian

[asfimport]

Brian Tully (migrated from Bugzilla):
I'm confirming that it is fixed for me as well, on my Mac, with the latest trunk build.

Is there any way to use the same rsyntaxtextarea class for the Response Body textarea within View Results Tree? Right now it just shows as plain text in sans-serif font, which is not exactly helpful when debugging.

I've updated my old bug at #5507 to see if that enhancement might be doable now that Darklaf and rsyntaxtextarea is fixed in trunk :)