Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider UTF-8 as the default HTTP encoding #6005

Closed
vlsi opened this issue Jun 25, 2023 · 2 comments · Fixed by #6010
Closed

Consider UTF-8 as the default HTTP encoding #6005

vlsi opened this issue Jun 25, 2023 · 2 comments · Fixed by #6010
Labels
enhancement to-triage
Milestone
5.6.1

Comments

@vlsi
Copy link
Collaborator

vlsi commented Jun 25, 2023 •
edited
Loading

Use case

Sending unicode data should not corrupt it.

Possible solution

We might consider using UTF-8 by default instead of the current ISO_8859_1.

See

jmeter/src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/sampler/PostWriter.java

Line 52 in 13793b7

public static final String ENCODING = StandardCharsets.ISO_8859_1.name();

See

Possible workarounds

No response

JMeter Version

5.5

Java Version

No response

OS Version

No response
@vlsi vlsi modified the milestones: 5.6.1, 5.7 Jun 25, 2023
vlsi added a commit to vlsi/jmeter that referenced this issue Jun 26, 2023
@vlsi
fix: use UTF-8 as a default encoding in HTTP sampler
93a162c 
In PR 5987 HTTP sampler encoded filenames with percent encoding,
however, it should not encode all the characters.


Fixes apache#6005
This is a fixup to apache#5987
@vlsi vlsi mentioned this issue Jun 26, 2023
Merged
vlsi added a commit to vlsi/jmeter that referenced this issue Jun 26, 2023
@vlsi
fix: use UTF-8 as a default encoding in HTTP sampler
06c7a27 
In PR 5987 HTTP sampler encoded filenames with percent encoding,
however, it should not encode all the characters.


Fixes apache#6005
This is a fixup to apache#5987
vlsi added a commit to vlsi/jmeter that referenced this issue Jun 27, 2023
@vlsi
fix: use UTF-8 as a default encoding in HTTP sampler
d58d07b 
In PR 5987 HTTP sampler encoded filenames with percent encoding,
however, it should not encode all the characters.

Fixes apache#6005
This is a fixup to apache#5987
vlsi added a commit to vlsi/jmeter that referenced this issue Jun 27, 2023
@vlsi
fix: use UTF-8 as a default encoding in HTTP sampler
6a537f4 
In PR 5987 HTTP sampler encoded filenames with percent encoding,
however, it should not encode all the characters.

Fixes apache#6005
This is a fixup to apache#5987
vlsi added a commit to vlsi/jmeter that referenced this issue Jun 27, 2023
@vlsi
fix: use UTF-8 as a default encoding in HTTP sampler
2a45d8c 
In PR 5987 HTTP sampler encoded filenames with percent encoding,
however, it should not encode all the characters.

Fixes apache#6005
This is a fixup to apache#5987
vlsi added a commit to vlsi/jmeter that referenced this issue Jun 28, 2023
@vlsi
fix: use UTF-8 as a default encoding in HTTP sampler
de8f6c0 
In PR 5987 HTTP sampler encoded filenames with percent encoding,
however, it should not encode all the characters.

Fixes apache#6005
This is a fixup to apache#5987
vlsi added a commit to vlsi/jmeter that referenced this issue Jun 28, 2023
@vlsi
fix: use UTF-8 as a default encoding in HTTP sampler
3b110ed 
In PR 5987 HTTP sampler encoded filenames with percent encoding,
however, it should not encode all the characters.

Fixes apache#6005
This is a fixup to apache#5987
vlsi added a commit to vlsi/jmeter that referenced this issue Jun 28, 2023
@vlsi
fix: use UTF-8 as a default encoding in HTTP sampler
5bfceca 
In PR 5987 HTTP sampler encoded filenames with percent encoding,
however, it should not encode all the characters.

Fixes apache#6005
This is a fixup to apache#5987
@vlsi vlsi modified the milestones: 5.7, 5.6.1 Jun 29, 2023
@vlsi vlsi closed this as completed in 7450e4b Jun 29, 2023
@koudela5
Copy link

koudela5 commented Jul 3, 2023 •
edited
Loading

I wonder if following lines (the information about the default encoding) in jmeter.properties are still valid based on this change:
#The encoding to be used if none is provided (default ISO-8859-1)
#sampleresult.default.encoding=ISO-8859-1

@vlsi
Copy link
Collaborator Author

vlsi commented Jul 3, 2023

Good catch. I somehow missed that org.apache.jmeter.samplers.SampleResult#DEFAULT_HTTP_ENCODING was used as a fallback for org.apache.jmeter.samplers.SampleResult#DEFAULT_ENCODING.

vlsi added a commit to vlsi/jmeter that referenced this issue Jul 3, 2023
@vlsi
doc: update documentation for sampleresult.default.encoding default v…
e3bb19b 
…alue

sampleresult.default.encoding defaults to DEFAULT_HTTP_ENCODING which moved
to UTF-8, so updating the documentation accordingly.

See apache#6005 (comment)
@vlsi vlsi mentioned this issue Jul 3, 2023
Merged
vlsi added a commit to vlsi/jmeter that referenced this issue Jul 3, 2023
@vlsi
doc: update documentation for sampleresult.default.encoding default v…
4340b2a 
…alue

sampleresult.default.encoding defaults to DEFAULT_HTTP_ENCODING which moved
to UTF-8, so updating the documentation accordingly.

See apache#6005 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement to-triage
Projects
None yet
Milestone
5.6.1
Development

Successfully merging a pull request may close this issue.

fix: use UTF-8 as a default encoding in HTTP sampler vlsi/jmeter
2 participants
@vlsi @koudela5