New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed functions.util.* as they don't seem to be used (for many years). #335

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@ham1

ham1 commented Nov 21, 2017

Description

Remove files which don't seem to be used, they have a TODO comment from 2008 and hasn't been meaningfully changed since 2003.

How Has This Been Tested?

Unit tests.

@codecov-io

This comment has been minimized.

codecov-io commented Nov 21, 2017

Codecov Report

Merging #335 into trunk will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk     #335      +/-   ##
============================================
+ Coverage     57.91%   57.91%   +<.01%     
+ Complexity    10025    10024       -1     
============================================
  Files          1148     1146       -2     
  Lines         73789    73781       -8     
  Branches       7328     7328              
============================================
- Hits          42734    42733       -1     
+ Misses        28577    28570       -7     
  Partials       2478     2478
Impacted Files Coverage Δ Complexity Δ
...c/core/org/apache/jmeter/reporters/Summariser.java 85.38% <0%> (-0.77%) 18% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc60e7...38a6e30. Read the comment docs.

@asfgit asfgit closed this in 4bdb53d Nov 23, 2017

@ham1 ham1 deleted the ham1:remove_unused_functions.util branch Nov 23, 2017

asfgit pushed a commit that referenced this pull request Nov 25, 2017

Removed functions.util.* as they don't seem to be used (for many years)
This closes #335
Contributed by Graham Russell

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1816337 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment