Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csv sample reader fix #368

Closed
wants to merge 2 commits into from
Closed

Csv sample reader fix #368

wants to merge 2 commits into from

Conversation

ham1
Copy link
Contributor

@ham1 ham1 commented Dec 23, 2017

unless my understanding is incorrect then it seems row wasn't being incremented.

@codecov-io
Copy link

Codecov Report

Merging #368 into trunk will increase coverage by 0.01%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk     #368      +/-   ##
============================================
+ Coverage     58.35%   58.36%   +0.01%     
- Complexity    10288    10290       +2     
============================================
  Files          1164     1164              
  Lines         74127    74126       -1     
  Branches       7298     7298              
============================================
+ Hits          43254    43266      +12     
+ Misses        28359    28349      -10     
+ Partials       2514     2511       -3
Impacted Files Coverage Δ Complexity Δ
...apache/jmeter/report/core/CsvSampleReaderTest.java 78.18% <100%> (+4.49%) 11 <1> (-1) ⬇️
...org/apache/jmeter/report/core/CsvSampleReader.java 57.57% <50%> (+0.65%) 12 <0> (ø) ⬇️
src/core/org/apache/jmeter/report/core/Sample.java 41.02% <0%> (+2.56%) 11% <0%> (+1%) ⬆️
...mpler/hc/JMeterPoolingClientConnectionManager.java 30.95% <0%> (+3.17%) 11% <0%> (+1%) ⬆️
...re/org/apache/jmeter/engine/DistributedRunner.java 85.95% <0%> (+4.13%) 32% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998b330...083b1ae. Read the comment docs.

@asfgit asfgit closed this in b15d5b8 Dec 23, 2017
@ham1 ham1 deleted the CsvSampleReader_fix branch December 24, 2017 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants