Fix 62887. Customized SampleLabel is ignored and overwritten by JMet… #429

artem-fedorov · 2018-11-09T09:55:40Z

…er 5.0

…r 5.0

codecov-io · 2018-11-09T15:18:12Z

Codecov Report

Merging #429 into trunk will increase coverage by <.01%.
The diff coverage is 72%.

@@             Coverage Diff             @@
##              trunk    #429      +/-   ##
===========================================
+ Coverage     58.59%   58.6%   +<.01%     
- Complexity    10632   10637       +5     
===========================================
  Files          1196    1196              
  Lines         76051   76072      +21     
  Branches       7357    7357              
===========================================
+ Hits          44562   44579      +17     
- Misses        28981   28984       +3     
- Partials       2508    2509       +1

Impacted Files	Coverage Δ	Complexity Δ
...c/org/apache/jmeter/samplers/TestSampleResult.java	`94.3% <100%> (+0.44%)`	`25 <1> (+1)`	⬆️
.../core/org/apache/jmeter/samplers/SampleResult.java	`74.66% <36.36%> (-0.98%)`	`135 <4> (+2)`
...c/core/org/apache/jmeter/reporters/Summariser.java	`86.25% <0%> (+1.52%)`	`19% <0%> (+2%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3540949...9eee458. Read the comment docs.

pmouawad · 2018-11-09T20:40:02Z

bin/testfiles/Bug52310.xml

@@ -2,16 +2,16 @@
 <testResults version="1.2">
 <sample s="true" lb="ComputeIPAddr" rc="200" rm="OK" dt="text"/>
 <httpSample s="true" lb="HTTP-Request-HC31" rc="200" rm="OK" dt="text">
-  <httpSample s="true" lb="HTTP-Request-HC31-0" rc="200" rm="OK" dt="text"/>


I don't understand why this test result is modified.
The result should be numbered sub results no ?

From the bug I understand, that JMeter will change subResults labels only if this labels are equals.
The parent label is HTTP-Request-HC31, subResults labels start with http://jmeter.apache.org/..... They are not equals and JMeter does not change them.

pmouawad · 2018-11-09T20:40:32Z

bin/testfiles/HTMLParserTestFile_2.xml

@@ -10,7 +10,7 @@
    <queryString class="java.lang.String"></queryString>
    <java.net.URL>file:testfiles/HTMLParserTestFile_2.html</java.net.URL>
  </httpSample>
-  <httpSample s="true" lb="file:testfiles/HTMLParserTestFile_2.html-1" rc="200" rm="OK" tn="Thread Group 1-1" dt="text" de="" by="1321" sc="1" ec="0" ng="1" na="1">


Same note here

pmouawad · 2018-11-09T20:40:42Z

bin/testfiles/HTMLParserTestFile_2.xml

@@ -10,7 +10,7 @@
    <queryString class="java.lang.String"></queryString>
    <java.net.URL>file:testfiles/HTMLParserTestFile_2.html</java.net.URL>
  </httpSample>
-  <httpSample s="true" lb="file:testfiles/HTMLParserTestFile_2.html-1" rc="200" rm="OK" tn="Thread Group 1-1" dt="text" de="" by="1321" sc="1" ec="0" ng="1" na="1">
+  <httpSample s="true" lb="file:testfiles/HTMLParserTestFile_2_files/style.css" rc="200" rm="OK" tn="Thread Group 1-1" dt="text" de="" by="1321" sc="1" ec="0" ng="1" na="1">


Same note here

pmouawad · 2018-11-09T20:42:02Z

bin/testfiles/TEST_HTTP_HttpClient4.xml

@@ -144,7 +144,7 @@
  <httpSample s="true" lb="HR-FollowRedirect-18" rc="302" dt="text"/>
  <httpSample s="true" lb="HR-FollowRedirect-19" rc="302" dt="text"/>
  <httpSample s="true" lb="HR-FollowRedirect-20" rc="302" dt="text"/>
-  <httpSample s="false" lb="HR-FollowRedirect-21" rc="Non HTTP response code: java.io.IOException" dt="text"/>


I don't understand this modification. Why 20 instead of 21 ?

Because first 20 subSamples were added here and the last SampleResult was generated from previous SubResult (that was renamed) and added here.

If you expect HR-FollowRedirect-21 here we can fix it using this small hack:

if (redirect >= MAX_REDIRECTS) { lastRes = errorResult(new IOException("Exceeded maximum number of redirects: " + MAX_REDIRECTS), new HTTPSampleResult(lastRes)); lastRes.setSampleLabel(totalRes.getSampleLabel()); // use parent label totalRes.addSubResult(lastRes); }

pmouawad · 2018-11-09T20:42:10Z

bin/testfiles/TEST_HTTP_Java.xml

@@ -120,7 +120,7 @@
  <httpSample s="true" lb="HR-FollowRedirect-18" rc="302" dt="text"/>
  <httpSample s="true" lb="HR-FollowRedirect-19" rc="302" dt="text"/>
  <httpSample s="true" lb="HR-FollowRedirect-20" rc="302" dt="text"/>
-  <httpSample s="false" lb="HR-FollowRedirect-21" rc="Non HTTP response code: java.io.IOException" dt="text"/>


Same note here

pmouawad · 2018-11-09T20:43:04Z

Thanks Artem for the PR, but I don't understand it.
It seems to me it breaks what has been modified in 5.0.

pmouawad · 2018-11-22T19:23:21Z

Hi @artem-fedorov,
Is it ok if we stay as we are ?
Reporter of issue says it’s ok for him.
Do you see any issue on your side that would need a fix ?

Thanks

artem-fedorov · 2018-11-23T10:51:16Z

@pmouawad
In case when I have 3 resources for request url.com

url.com/res.css
url.com/res.html
url.com/res.xml
Does current behaviour guaranteed that url.com/res.css always will have label url-0, url.com/res.html -> url.com-1 and url.com/res.xml -> url.com-2 ? and Labels will not be confused?

pmouawad · 2018-11-23T10:54:58Z

Hello @artem-fedorov ,
Yes if they are in the test plan.
No guarantee if they are automatically handled by resources download and it is done in parallel, but since 5.0, we add the URL in the CSV to disambiguate

pmouawad · 2019-02-04T12:37:16Z

Hello @artem-fedorov ,

There seem to be a place for this PR amended for users that use JMeter for functional testing as per the 2 last comments in:

https://bz.apache.org/bugzilla/show_bug.cgi?id=63055

Would you be ready to amend your PR to have old behaviour only if:

Test Plan has checked "Functional Test Mode"
There is a property "functional_mode=true"

Thanks

artem-fedorov · 2019-02-04T14:13:15Z

Hello @pmouawad
I'll create a new PR soon

…losing issue. This closes apache#429 Bugzilla Id: 62887 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1849497 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 7f4da0e

Artem Fedorov added 9 commits November 9, 2018 12:54

Fix 62887. Customized SampleLabel is ignored and overwritten by JMete…

561e26c

…r 5.0

fixed HTMLParserTestFile_2.jmx test

1a46dcc

revert tests for Bug 62550

ec37a00

fix test

415130e

fix test2

3b1647d

fix test3

57f6311

fix test4

ae75c8f

fix test5

dd893ad

fix test 6

9eee458

pmouawad reviewed Nov 9, 2018

View reviewed changes

asfgit closed this in 7f4da0e Dec 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 62887. Customized SampleLabel is ignored and overwritten by JMet… #429

Fix 62887. Customized SampleLabel is ignored and overwritten by JMet… #429

artem-fedorov commented Nov 9, 2018

codecov-io commented Nov 9, 2018

pmouawad Nov 9, 2018

artem-fedorov Nov 12, 2018

pmouawad Nov 9, 2018

artem-fedorov Nov 12, 2018

pmouawad Nov 9, 2018

pmouawad Nov 9, 2018

artem-fedorov Nov 12, 2018

artem-fedorov Nov 13, 2018

pmouawad Nov 9, 2018

artem-fedorov Nov 12, 2018

pmouawad commented Nov 9, 2018

pmouawad commented Nov 22, 2018

artem-fedorov commented Nov 23, 2018

pmouawad commented Nov 23, 2018 •

edited

pmouawad commented Feb 4, 2019

artem-fedorov commented Feb 4, 2019

Fix 62887. Customized SampleLabel is ignored and overwritten by JMet… #429

Fix 62887. Customized SampleLabel is ignored and overwritten by JMet… #429

Conversation

artem-fedorov commented Nov 9, 2018

codecov-io commented Nov 9, 2018

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pmouawad commented Nov 9, 2018

pmouawad commented Nov 22, 2018

artem-fedorov commented Nov 23, 2018

pmouawad commented Nov 23, 2018 • edited

pmouawad commented Feb 4, 2019

artem-fedorov commented Feb 4, 2019

pmouawad commented Nov 23, 2018 •

edited