Migrate build system to Gradle #469

vlsi · 2019-06-17T20:14:32Z

This is revival of #448

Note: below tricks might help to hide file movements:
A) GitHub UI: scroll the diff ("files changed") to the very end, and type the following to the browser console: $$('div.empty').forEach(function(e) { e.parentElement.parentElement.style.display='none'; })

B) You can watch individual commits (e.g. open Commits ) and review individual ones

C) You can use git log -M30% -l0 --stat -p -G. on the command line to show non-trivial diffs only (hide movements)

D) You can use git diff -M30% -l0 --stat -p -G. origin/master to see the full diff

Note GitHub has a limit on the number of renamed files, so sometimes it shows a file as "deleted and inserted" even if that was a simple rename.

-l0 can be used to set "unlimited" number of "renamed files" in git diff / git log.

Then the diff shows 152 files changed, 5046 insertions(+), 10204 deletions(-).

Note: license verification, IDE configuration, and release plugin is moved to https://github.com/vlsi/vlsi-release-plugins.
It reduces JMeter build scripts by ~1500 lines, and it improves build time (pre-built plugins are reused instead of building it from source).

vlsi · 2019-06-17T20:15:44Z

Dependency with "manual" license configuration: dnsjava/dnsjava#63

vlsi · 2019-06-17T20:16:18Z

Dependency with "manual" license configuration: oblac/jodd#717

vlsi · 2019-06-17T20:16:46Z

Dependency with "manual" license configuration: bulenkov/Darcula#53

vlsi · 2019-06-17T20:19:32Z

Dependency with "manual" license configuration: json-path/JsonPath#550

vlsi · 2019-06-17T20:19:46Z

Dependency with "manual" license configuration: bobbylight/RSyntaxTextArea#299

vlsi · 2019-06-17T20:20:12Z

Dependency with "manual" license configuration: x-stream/xstream#151

vlsi · 2019-06-17T20:22:46Z

Dependency with "manual" license configuration: google/brotli#758

vlsi · 2019-06-17T21:06:07Z

Dependency with "manual" license configuration: ben-manes/caffeine#325

pmouawad

Hello @vlsi ,
First, thanks for this big piece of work, volume of work is pretty big !

I made a first review, I didn't expect migration from Ant to Gradle would lead to so much code to be frank.
As of me, for now I don't feel comfortable maintaining this new code but I guess it will come.
Anyway, maybe it would help a bit to create or update doc with something like:

Old Ant feature => Location / classes in Gradle
Example:
ApacheJMeter_parent.xml => Location where it is generated
...

Thanks

build.gradle.kts

pmouawad · 2019-06-22T15:27:36Z

buildSrc/build.gradle.kts

+ * limitations under the License.
+ *
+ */
+


Just for maintenance and Gradle newbies, add a header comment explaining aim of the file ?

I just thought "gradle buildsrc" Google search answers those kind of questions.
Do you still think it is worth clarifying?

buildSrc/subprojects/release/src/main/kotlin/org/apache/jmeter/buildtools/AutoClassifySpec.kt

buildSrc/subprojects/release/src/main/kotlin/org/apache/jmeter/buildtools/jgit/dsl/Git.kt

src/build.gradle.kts

vlsi · 2019-06-23T14:42:52Z

Anyway, maybe it would help a bit to create or update doc with something like:

@pmouawad , have you seen https://github.com/apache/jmeter/blob/1a70d90e71b00d813ad0735ee9063c4f9e1f0808/gradle.md ?
I think it covers all of the use cases.
If you think something is missing, feel free to comment.

However, I do not think we really need a dictionary that maps "old Ant feature" to "Gradle feature".

99% of the times one would be fine with just trying gw tasks (./gradlew tasks) to see the possible tasks, and 100% of the times, the output is placed into build/ folder. So one can just open build/ folder and find the content there as required.

codecov-io · 2019-07-01T20:51:41Z

Codecov Report

❗ No coverage uploaded for pull request base (master@bb89778). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #469   +/-   ##
=========================================
  Coverage          ?   53.53%           
  Complexity        ?     9389           
=========================================
  Files             ?     1008           
  Lines             ?    61671           
  Branches          ?     6913           
=========================================
  Hits              ?    33013           
  Misses            ?    26260           
  Partials          ?     2398

Impacted Files	Coverage Δ	Complexity Δ
...ache/jmeter/modifiers/BSFPreProcessorBeanInfo.java	`100% <ø> (ø)`	`1 <0> (?)`
.../apache/jmeter/modifiers/gui/CounterConfigGui.java	`73.01% <ø> (ø)`	`7 <0> (?)`
...va/org/apache/jmeter/visualizers/utils/Colors.java	`50% <ø> (ø)`	`3 <0> (?)`
...ava/org/apache/jmeter/assertions/XMLAssertion.java	`59.25% <ø> (ø)`	`3 <0> (?)`
...ava/org/apache/jmeter/extractor/HtmlExtractor.java	`86.23% <ø> (ø)`	`41 <0> (?)`
...jmeter/timers/ConstantThroughputTimerBeanInfo.java	`100% <ø> (ø)`	`1 <0> (?)`
.../jmeter/visualizers/XMLDefaultMutableTreeNode.java	`6.66% <ø> (ø)`	`2 <0> (?)`
...ache/jmeter/timers/gui/AbstractRandomTimerGui.java	`87.23% <ø> (ø)`	`5 <0> (?)`
...n/java/org/apache/jmeter/visualizers/BarGraph.java	`50% <ø> (ø)`	`3 <0> (?)`
...rg/apache/jmeter/visualizers/TreeNodeRenderer.java	`66.66% <ø> (ø)`	`3 <0> (?)`
... and 190 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb89778...fac1ca7. Read the comment docs.

frschwab · 2019-07-25T21:55:11Z

Hi, I only get the follwing tasks shown after checking out your repo:

gw tasks

Build Setup tasks
init - Initializes a new Gradle build.
wrapper - Generates Gradle wrapper files.

gw runGui doesn't show up nor work.
How to build the project?

vlsi · 2019-07-26T12:56:08Z

@frschwab , you have to be using gradle branch.

For instance:

git clone -b gradle https://github.com/vlsi/jmeter.git jmeter_vlsi
cd jmeter_vlsi
gw tasks

frschwab · 2019-07-26T20:49:19Z

@frschwab , you have to be using gradle branch.

For instance:
git clone -b gradle https://github.com/vlsi/jmeter.git jmeter_vlsi
cd jmeter_vlsi
gw tasks

I checked it out. I ran gw init and gw wrapper and gw eclipse.
I imported gradle project into eclipse 2019.6.
I also merged from apache master branch.

This is the errors i get in eclipse:

vlsi · 2019-07-29T07:46:14Z

I also merged from apache master branch.

Why?

frschwab · 2019-07-29T09:23:07Z

I also merged from apache master branch.

Why?

I thought I could get rid of the error messages. But I get the exact same messages if I do not merge apache master branch into vlsi gradle - I just tried it out again.

vlsi · 2019-07-29T10:34:15Z

I have rebased the branch, moved engine.report... to to the appropriate folder, and made jmeterversion genration task is invoked by Eclipse on project import.

Please retry.

I don't use Eclipse, however I tried to import the project, and it works for me.

vlsi · 2019-07-30T11:10:49Z

Dependency with "manual" license configuration: eXparity/hamcrest-date#26

vlsi · 2019-07-30T11:18:31Z

Dependency with "manual" license configuration: hamcrest/JavaHamcrest#264

frschwab · 2019-07-31T09:01:46Z

One final thing from my side:
I don't know if that is possible or best practice in Gradle, but I think it would be user friendly if gw tasks showed only the main tasks that are used most of the time, and something like gw tasks --all showed them all (like currently) or gw tasks --testing for example showed only all tasks in the testing topic.
Otherwise, you really have to scroll up a lot on the console ;-)
Thanks for your work, also on how-to integrate into eclipse!

vlsi · 2019-07-31T09:21:28Z

I don't know if that is possible or best practice in Gradle, but I think it would be user friendly if gw tasks showed only the main tasks

It is funny I was thinking behind exactly those lines, and I have already hidden a couple of tasks:
vlsi/vlsi-release-plugins@bd91637

It is kind of hard to tell what are those "main" tasks.
It would be nice if you could go through the list of tasks and classify them.

Frankly speaking, I don't like Gradle's verbosity on generateMetadataFileForCorePublication / generatePomFileForCorePublication / publishCorePublicationToMavenLocal / publishCorePublicationToNexusRepository
It looks like those tasks are the most offenders.

I would try to hide those, and replace with something like "generatePom".
For instance, currently we have "test - Runs the unit tests" task which is printed just once even though the task exists in logs of subprojects.

gw tasks --testing

Do you refer to batch test tasks?
Hiding those under --testing flag indeed makes sense.
Thanks. That is nice.

frschwab · 2019-07-31T09:41:59Z

It would be nice if you could go through the list of tasks and classify them.

I can try to find some time in the next days.

Frankly speaking, I don't like Gradle's verbosity on generateMetadataFileForCorePublication / generatePomFileForCorePublication / publishCorePublicationToMavenLocal / publishCorePublicationToNexusRepository
It looks like those tasks are the most offenders.

I just found out that e.g. gw runG also works and it executes runGui task. Though it doesn't do autocomplete on the command line itself ;-)

gw tasks --testing

Do you refer to batch test tasks?
Hiding those under --testing flag indeed makes sense.
Thanks. That is nice.

Yes, I thought about the long list of batch tests in the first section.
That was just an example pseudo code, a more precise name would make more sense, not to be confused with gw test

Also seems like these sections are getting ordered alphabetically, which is maybe not the same order in which someone would call these tasks.

vlsi · 2019-07-31T11:54:31Z

Also seems like these sections are getting ordered alphabetically, which is maybe not the same order in which someone would call these tasks.

I've created gradle/gradle#10133

Former-commit-id: 6a199bf

Former-commit-id: 2f5beda

Former-commit-id: 42ab564

Former-commit-id: 39fab54

Former-commit-id: 4e3f58e

vlsi · 2020-02-14T18:04:28Z

Dependency with "manual" license configuration: weisJ/darklaf#22

pmouawad requested changes Jun 22, 2019

View reviewed changes

vlsi force-pushed the gradle branch 3 times, most recently from a5ad14f to 97e0d24 Compare June 28, 2019 20:25

vlsi changed the title ~~WIP: Migrate build system to Gradle~~ Migrate build system to Gradle Jun 28, 2019

vlsi mentioned this pull request Jul 13, 2019

Missing LICENSE file. 6pac/SlickGrid#390

Closed

2 tasks

vlsi force-pushed the gradle branch 5 times, most recently from 734be13 to 1c9c7ab Compare July 19, 2019 16:24

vlsi mentioned this pull request Jul 19, 2019

JDBC Request: Allow to only fetch a certain number of rows #476

Merged

3 tasks

vlsi force-pushed the gradle branch from 1c9c7ab to b84c11b Compare July 19, 2019 18:59

vlsi force-pushed the gradle branch from b84c11b to 88b8eca Compare July 29, 2019 10:31

vlsi force-pushed the gradle branch 4 times, most recently from 3aa2763 to 46a9013 Compare July 30, 2019 16:05

vlsi force-pushed the gradle branch from 46a9013 to 5354165 Compare August 1, 2019 21:46

vlsi added 6 commits August 2, 2019 00:56

Move source files to new layout

f6dafdf

Former-commit-id: 6a199bf

Fix resources.PackageTest

511ee5a

Former-commit-id: 2f5beda

Remove java.class.path filtering from ClassFinder

f0417ec

Former-commit-id: 42ab564

Fix functions.PackageTest#BSH1: move bsh file to resources folder

bf1dc4a

Former-commit-id: 39fab54

Remove obsolete files

f1933cc

Former-commit-id: 4e3f58e

Add Kotlin files to checkstyle.xml

77c756c

vlsi force-pushed the gradle branch 4 times, most recently from 23ddb0a to 4dd6da3 Compare August 2, 2019 11:41

Add Gradle build scripts

2be94e8

vlsi force-pushed the gradle branch from 4dd6da3 to 2be94e8 Compare August 2, 2019 12:22

vlsi merged commit 2be94e8 into apache:master Aug 2, 2019

vlsi mentioned this pull request Sep 16, 2019

New JMESPATH extractor #489

Merged

4 tasks

vlsi mentioned this pull request Feb 25, 2020

Clarify license terms, include license to the jar files javacc21/javacc21#16

Closed

vlsi mentioned this pull request May 30, 2022

Gradle build system assertj/assertj#277

Closed

vlsi mentioned this pull request Nov 2, 2022

[license-gather-plugin] Ability to handle multiple licensed artefacts vlsi/vlsi-release-plugins#54

Open

vlsi mentioned this pull request Apr 28, 2023

Please bundle LICENSE/NOTICE files in the produced jar files wrandelshofer/FastDoubleParser#38

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate build system to Gradle #469

Migrate build system to Gradle #469

vlsi commented Jun 17, 2019 •

edited

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

pmouawad left a comment

pmouawad Jun 22, 2019

vlsi Jun 28, 2019

vlsi commented Jun 23, 2019

codecov-io commented Jul 1, 2019 •

edited

frschwab commented Jul 25, 2019 •

edited

vlsi commented Jul 26, 2019

frschwab commented Jul 26, 2019

vlsi commented Jul 29, 2019

frschwab commented Jul 29, 2019

vlsi commented Jul 29, 2019

vlsi commented Jul 30, 2019

vlsi commented Jul 30, 2019

frschwab commented Jul 31, 2019

vlsi commented Jul 31, 2019

frschwab commented Jul 31, 2019 •

edited

vlsi commented Jul 31, 2019

vlsi commented Feb 14, 2020

Migrate build system to Gradle #469

Migrate build system to Gradle #469

Conversation

vlsi commented Jun 17, 2019 • edited

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

vlsi commented Jun 17, 2019

pmouawad left a comment

Choose a reason for hiding this comment

pmouawad Jun 22, 2019

Choose a reason for hiding this comment

vlsi Jun 28, 2019

Choose a reason for hiding this comment

vlsi commented Jun 23, 2019

codecov-io commented Jul 1, 2019 • edited

Codecov Report

frschwab commented Jul 25, 2019 • edited

vlsi commented Jul 26, 2019

frschwab commented Jul 26, 2019

vlsi commented Jul 29, 2019

frschwab commented Jul 29, 2019

vlsi commented Jul 29, 2019

vlsi commented Jul 30, 2019

vlsi commented Jul 30, 2019

frschwab commented Jul 31, 2019

vlsi commented Jul 31, 2019

frschwab commented Jul 31, 2019 • edited

vlsi commented Jul 31, 2019

vlsi commented Feb 14, 2020

vlsi commented Jun 17, 2019 •

edited

codecov-io commented Jul 1, 2019 •

edited

frschwab commented Jul 25, 2019 •

edited

frschwab commented Jul 31, 2019 •

edited