Fix NumberFormatException when counter is empty or not a digit on Proxy Settings panel #5901
Conversation
milamberspace
force-pushed
the
Fix_NFE_on_counter_button
branch
from
5de7deb
to
e368513
Compare
| JOptionPane.showMessageDialog(this, | ||
| //"Counter isn't a number value.", "Error on counter value", JOptionPane.WARNING_MESSAGE); | ||
| JMeterUtils.getResString("proxy_settings_counter_error_digits"), // $NON-NLS-1$ | ||
| JMeterUtils.getResString("proxy_settings_counter_error_invalid_data"), // $NON-NLS-1$ | ||
| JOptionPane.WARNING_MESSAGE); |
There was a problem hiding this comment.
Could you add the problematic value to the error message?
There was a problem hiding this comment.
Will it support ${...} expressions?
There was a problem hiding this comment.
@vlsi what is ${...} expressions? I don't understand
Not sure that add the problematic value is needed, specially if the value is empty. IMO only display a warning is ok.
There was a problem hiding this comment.
E.g. something like ${__P(staringValue)}
There was a problem hiding this comment.
Ok, I see the number was already parsed without evaluating the properties, so supporting ${..} there would be a different issue
There was a problem hiding this comment.
Seems usual to not evaluate the value against the JMeter function for the Proxy settings. Proxy is use only on GUI mode, not in load tests, so it's not need to evaluate the value if ${...} expression is present. Are you ok with this?
There was a problem hiding this comment.
I have no use case for evaluation ${..} there yet, however, I think having uniform support for ${..} would be nice
There was a problem hiding this comment.
This PR aims first to correct the NFE (which is a technical error), and not to make improvements in the Counter field. If there is a need to add functionality for evaluating JMeter functions, that will be the subject of another ticket. Can I have your LGTM?
There was a problem hiding this comment.
That works for me. However, would you please include the problematic value itself in the error message?
…xy Settings panel
milamberspace
force-pushed
the
Fix_NFE_on_counter_button
branch
from
e368513
to
45eff09
Compare
vlsi
changed the title
… is empty or not a digit on Proxy Settings panel)
Description
On proxy settings, if the Counter is empty or not a numeric value, when you click on Set Counter button, JMeter have a NumberFormatException
2023-05-04 17:10:42,819 ERROR o.a.j.JMeter: Uncaught exception in thread Thread[AWT-EventQueue-0,6,main]
java.lang.NumberFormatException: For input string: ""
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) ~[?:?]
at java.lang.Integer.parseInt(Integer.java:678) ~[?:?]
at java.lang.Integer.parseInt(Integer.java:786) ~[?:?]
at org.apache.jmeter.protocol.http.proxy.gui.ProxyControlGui.lambda$createHTTPSamplerPanel$1(ProxyControlGui.java:985) ~[ApacheJMeter_http.jar:5.4.3]
Motivation and Context
This PR fix this issue with a test on the value, and display a popup if not a digit value
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: