fix: after disabling the Java Request sampler, it cannot be enabled again - #6012
Merged
Conversation
…gain Java sampler was inheriting "enabled" status from its config element as internally, Java Sampler UI always creates a config element and merges it to the java sampler. The solution is to move "configureTestElement(sampler);" to the very end of modifyTestElement so all the base properties are populated based on the element properties rather than "config element" properties. Ideally we should somehow limit "mergeIn", and we should refrain from merging unexpected properties. Fixes apache#6004
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java sampler was inheriting "enabled" status from its config element as internally, Java Sampler UI always creates a config element and merges it to the java sampler.
The solution is to move "configureTestElement(sampler);" to the very end of modifyTestElement so all the base properties are populated based on the element properties rather than "config element" properties.
Ideally, we should somehow limit "mergeIn", and we should refrain from merging unexpected properties.
Fixes #6004