fix: log errors happening while JMeter starts the test #6193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the exceptions from TestStateListener.testStarted might be unnoticed since the UI did not display them. This change is a workaround to surface errors in common cases. See apache#6174
vlsi
force-pushed
the
log_error
branch
2 times, most recently
from
b67a731
to
0e48ce8
Compare
…BCTestElement TestStateListener + TestBean cause issues like in apache#6174, so we should remove empty implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the exceptions from
TestStateListener.testStartedmight be unnoticed since the UI did not display them.This change is a workaround to surface errors in common cases.
We should make UI to monitor the running test, however, I would defer that to JMeter 6.0
See #6174