Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline binding of UI elements to TestElement properties #6199

Merged
merged 6 commits into from
Dec 27, 2023
Merged

Streamline binding of UI elements to TestElement properties #6199

merged 6 commits into from
Dec 27, 2023

Commits on Dec 27, 2023

  1. fix: allow setting empty strings with TestElement.set(...) API, and r… 

    …emove properties only in case the value is null
    @vlsi
    vlsi committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    ef82a00 View commit details
    Browse the repository at this point in the history

  2. fix: add property bindings to reduce code duplication in UI classes a… 

    …nd make "configure and modifyTestElement" simple in most cases
    @vlsi
    vlsi committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    9b25862 View commit details
    Browse the repository at this point in the history

  3. refactor: use property bindings in BeanShellSamplerGui

    @vlsi
    vlsi committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    1651026 View commit details
    Browse the repository at this point in the history

  4. refactor: use property bindings in ThreadGroupGui, OpenModelThreadGro… 

    …upGui
    @vlsi
    vlsi committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    2782476 View commit details
    Browse the repository at this point in the history

  5. refactor: use property bindings in TestPlanGui

    @vlsi
    vlsi committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    0d9c351 View commit details
    Browse the repository at this point in the history

  6. test: verify that GuiComponent.configure+modifyTestElement does not m… 

    …odify element after creation

It helps to verify both createTestElement, configure, and modifyTestElement implementations,
so JMeter does not accidentally show treat test plan as dirty when the user
merely switches across elements

At the same time, it ensures test elements do not accidentally lose properties
when processing modifyTestElement
    @vlsi
    vlsi committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    c3457ff View commit details
    Browse the repository at this point in the history