Reduce memory consumption by the logging panel (disable undo events for it) #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
force-pushed
the
logpanel_undo
branch
2 times, most recently
from
cd0bc4e
to
3543d86
Compare
|
Cool |
vlsi
force-pushed
the
logpanel_undo
branch
2 times, most recently
from
e43fa9f
to
062190a
Compare
…or it) There are two fixes: 1) undoManager.setLimit(0) -> setLimit(1) since (0) means "unlimited undo" See bobbylight/RSyntaxTextArea#99 2) By default, JMeter adds undoManager to ALL text fields via Swing updateUI method, so we need to explicitly uninstall it for the case when undo is not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
org.apache.jorphan.gui.ui.TextAreaUIWithUndo#createUIis called by Swing automatically by ALL text area components (since JMeter installsTextAreaUIWithUndoas a UI class for the look and feel).That is convenient since it makes all text fields and text areas support undo transparently, however, it results in surprising memory consumption by the logging panel.
Here's a heap dump:
TextComponentUI$1isUndoManager. I moved the anonymous class to a top-level named class so it is easier to understand in the future.How Has This Been Tested?
Test plan with JSR223 sampler that calls log.info("...") a lot.
After the change, the undo manager and text area are no longer in the top consumers.