Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSPWIKI-1137] - Minor Improvement #17

Merged
merged 2 commits into from
Dec 23, 2020
Merged

[JSPWIKI-1137] - Minor Improvement #17

merged 2 commits into from
Dec 23, 2020

Conversation

arturobernalg
Copy link
Member

@arturobernalg arturobernalg commented Dec 18, 2020 •
edited
Loading

  • Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1
  • Unnecessary semicolon ''
  • add final
  • Unnecessary 'null' check before 'equals()' call
  • Replace "UTF-8" for StandardCharsets.UTF_8.name()
  • Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1.name()

@arturobernalg
JSPWIKI-1137 - Minor Improvement
0ca9d9f 
* Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1
* Unnecessary semicolon ''
* add final
* Unnecessary 'null' check before 'equals()' call
* Replace "UTF-8" for StandardCharsets.UTF_8.name()
* Replace "ISO-8859-1"  for StandardCharsets.ISO_8859_1.name()
@arturobernalg
Copy link
Member Author

arturobernalg commented Dec 18, 2020 •
edited
Loading

Hi @juanpablo-santos
I'm very sorry for the line number and files changed. but i thing the change proposed it will improve the code

Pls let me know if you want me to change something

merry christmas

juanpablo-santos
juanpablo-santos approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@juanpablo-santos juanpablo-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes LGTM.

@juanpablo-santos juanpablo-santos merged commit b397525 into apache:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpablo-santos juanpablo-santos juanpablo-santos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@arturobernalg @juanpablo-santos