JSPWIKI-1188 system property expansion #330
Conversation
|
this actually didn't work when i tested it in tomcat. investigating now |
|
cycling back around to this. looks like the last commit i made does it fact work. |
* this ensures property load order remains as before, so we don't unexpectedly change resolved properties for anyone * more importantly, we also check for system env variables if the system property isn't defined. This allows us to check for things like i.e. * added javadocs here and there and some formatting changes along the way, and a new assertion on the test
|
Hi, just added a commit on the PR to also allow system env variable expansion, with the tests also passing; let's merge this and get a look to ci build then |
|
this is now merged in 2.12.2-git-13, thanks! :-) |
|
re. the build failure, MailUtilTest does send a mail to a local mailbox, and seems that up recently it doesn't allow mail sending if not using at least TLSv1.2. Currently running build at master should fix that issue, and I've also enabled console output on surefire on test failures/errors so hopefully debugging will be easier from now on. |
|
could try dumpster. it's a pure java, unit test only, mail server setup. We used it on apache juddi for integration tests. works fairly well for plain text stuff. never tried it with ssl though |
see https://issues.apache.org/jira/browse/JSPWIKI-1188