Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR increasing queued.max.requests for production recommendations in 0.9 and newer. #156

Closed
wants to merge 2 commits into from
Closed

Conversation

alexlod
Copy link

@alexlod alexlod commented Jul 25, 2018

No description provided.

@ijuma
Copy link
Contributor

ijuma commented Jul 29, 2018

Thanks for the PR. This change seems fine. For 0.11.0 and newer, we did a bit more:

apache/kafka@be98865#diff-22956c3cc0f5bb53d95fb30c9776f81d
apache/kafka@8bd8751#diff-22956c3cc0f5bb53d95fb30c9776f81d

Do we want to do the same here?

@alexlod
Copy link
Author

alexlod commented Jul 30, 2018

Good idea @ijuma. I forgot about that PR from way back then :). I updated this PR to be inline with what we changed back then.

Also, the change starting with <li>ZooKeeper removes a trailing space. I'm happy to get rid of that change if you'd like.

Thanks again!

@mjsax
Copy link
Member

mjsax commented Mar 28, 2021

Closing this PR as abandoned. (We can reopen if necessary.)

@mjsax mjsax closed this Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants