Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Remove redundant apostrophe in doc #325

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

showuon
Copy link
Contributor

@showuon showuon commented Jan 27, 2021

Found a redundant apostrophe appeared in doc.

image

Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

@mimaison mimaison merged commit b8c5173 into apache:asf-site Jan 28, 2021
@ableegoldman
Copy link
Contributor

@showuon just a heads up, you should fix this in kafka itself or the fix will get erased after each release. I managed to catch this for the 2.6.2 docs but for future feature releases they'll be copying it over fresh and wouldn't notice this even if they looked

@showuon
Copy link
Contributor Author

showuon commented Apr 21, 2021

@ableegoldman , thanks for your reminder! But I did also fix in kafka repo. Check here: apache/kafka#9976. Thank you for handling the 2.6.2 release. :)

@ableegoldman
Copy link
Contributor

Ah, I guess it just wasn't cherrypicked back to all the branches that were updated in the kafka-site PR. Sorry for the flase alarm 🙂

And it looks like that PR was merged before the 2.8 branch was cut, so this fix is probably safe going forward since we're unlikely to get another bugfix release older than 2.8 at this point. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants