-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: more powered by companies and updating apache logo #343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scott-confluent : Thanks for the PR.
Could we also link https://apache.org/logos/res/kafka/kafka_highres.png from http://kafka.apache.org/trademark ?
css/styles.css
Outdated
background-repeat: no-repeat; | ||
/* small: 168 x 50 */ | ||
} | ||
.page-dark .logo-link { | ||
background: url('/logos/kafka-white.svg'); | ||
background: url('/logos/kafka_logo--white-simple.png.svg'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kafka_logo--white-simple.png.svg => kafka_logo--white-simple.png ?
background-repeat: no-repeat; | ||
/* small: 168 x 50 */ | ||
} | ||
.page-dark .logo-link { | ||
background: url('/logos/kafka-white.svg'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the old logo image file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've cleaned up all the "dark theme" stuff, which included any of the white logos that were in use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scott-confluent : Thanks for the updated PR. LGTM
each new image has been optimized as well