New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and publish docs for 3.3 #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mumrah. Thanks for the change. Does this PR represent the docs in their latest state being pushed to the asf website? If so then it is definitely missing content from one PR. In general how can we verify the changes are complete?
@@ -3401,6 +3401,121 @@ <h4 class="anchor-heading"><a id="zkops" class="anchor-link"></a><a href="#zkops | |||
<li>Don't overbuild the cluster: large clusters, especially in a write heavy usage pattern, means a lot of intracluster communication (quorums on the writes and subsequent cluster member updates), but don't underbuild it (and risk swamping the cluster). Having more servers adds to your read capacity.</li> | |||
</ul> | |||
Overall, we try to keep the ZooKeeper system as small as will handle the load (plus standard growth capacity planning) and as simple as possible. We try not to do anything fancy with the configuration or application layout as compared to the official release as well as keep it as self contained as possible. For these reasons, we tend to skip the OS packaged versions, since it has a tendency to try to put things in the OS standard hierarchy, which can be 'messy', for want of a better way to word it. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some more changes in this file from the following PR apache/kafka#12679
Have those been pushed to the site already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did those changes get backported to the 3.3 branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do see it on the 3.3 branch -- apache/kafka@2e95280
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Rendering locally, the quickstart still refers to 3.2, though - I don't see how as the templateData.js
file is updated
@mumrah thanks for the update - I clicked around on a bunch of links and from what I can see the docs point to the correct ones, including the quickstart which points to 3.3 now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Refresh the latest 3.3.0 docs from the 3.3 branch, and update the top-level links to point to 3.3 docs.