Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Edoardo to committer list #475

Merged
merged 1 commit into from Jan 9, 2023
Merged

add Edoardo to committer list #475

merged 1 commit into from Jan 9, 2023

Conversation

edoardocomar
Copy link
Contributor

No description provided.

@edoardocomar
Copy link
Contributor Author

@mimaison @rajinisivaram
I do not understand if I should squash and merge myself or ask for approval ...

mimaison
mimaison approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats!

@mimaison
Copy link
Member

mimaison commented Jan 9, 2023

Approvals are not compulsory on kafka-site but typically it's still always best to get someone to take a look and approve. I've approved now, so feel free to merge.

@edoardocomar
Copy link
Contributor Author

Approvals are not compulsory on kafka-site but typically it's still always best to get someone to take a look and approve. I've approved now, so feel free to merge.

Thanks !

@edoardocomar edoardocomar merged commit 431414e into apache:asf-site Jan 9, 2023
@edoardocomar edoardocomar deleted the edocomar-committerlist branch January 9, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimaison mimaison mimaison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@edoardocomar @mimaison