Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break apart Streams docs #58

Closed

Conversation

derrickdoo
Copy link
Contributor

@derrickdoo derrickdoo commented May 30, 2017

  • Break apart Streams docs into 4 sections

remove debugger

support past versions of streams docs
@derrickdoo derrickdoo changed the title [PLEASE DO NOT MERGE] Further break apart Streams docs Break apart Streams docs Jun 30, 2017
Copy link
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise LGTM.

@@ -32,7 +32,8 @@
'streams',
'quickstart',
'toc',
'upgrade'
'upgrade',
'content'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this name a bit misleading.. could we rename it to streams-content or streams-subpages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this on purpose so we could have a generic name for containers that we know aren't going to rendered alongside themselves. It just makes it easier for other to copy and paste existing pages and build off of them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, makes sense.

@asfgit asfgit closed this in 04199a2 Jun 30, 2017
@guozhangwang
Copy link
Contributor

Merged to asf-site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants